public inbox for linux-rdma@vger.kernel.org
 help / color / mirror / Atom feed
From: Leon Romanovsky <leon@kernel.org>
To: Devesh Sharma <devesh.sharma@broadcom.com>
Cc: linux-rdma@vger.kernel.org
Subject: Re: [PATCH V5 for-next 1/3] RDMA/bnxt_re: Enable global atomic ops if platform supports
Date: Thu, 3 Jun 2021 08:57:03 +0300	[thread overview]
Message-ID: <YLhvL44jBi8HYCoR@unreal> (raw)
In-Reply-To: <20210602154618.973816-2-devesh.sharma@broadcom.com>

On Wed, Jun 02, 2021 at 09:16:16PM +0530, Devesh Sharma wrote:
> Enabling Atomic operations for Gen P5 devices if the underlying
> platform supports global atomic ops.
> 
> Fixes: 7ff662b76167 ("Disable atomic capability on bnxt_re adapters")

First, it looks to me like a feature and not Fix, so I'll be second to
Nicolas's request, please don't add Fixes line to every commit.

Second, even this is a dix, the fixes line is still wrong.
➜  kernel git:(rdma-next) git fixes 7ff662b76167
Fixes: 7ff662b76167 ("RDMA/bnxt_re: Disable atomic capability on bnxt_re adapters")

Thanks

  reply	other threads:[~2021-06-03  5:57 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-02 15:46 [PATCH V5 for-next 0/3] Broadcom's driver add global atomics Devesh Sharma
2021-06-02 15:46 ` [PATCH V5 for-next 1/3] RDMA/bnxt_re: Enable global atomic ops if platform supports Devesh Sharma
2021-06-03  5:57   ` Leon Romanovsky [this message]
2021-06-03 10:27     ` Devesh Sharma
2021-06-02 15:46 ` [PATCH V5 for-next 2/3] bnxt_re: Update maintainers list Devesh Sharma
2021-06-02 15:46 ` [PATCH V5 for-next 3/3] RDMA/bnxt_re: update ABI to pass wqe-mode to user space Devesh Sharma

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YLhvL44jBi8HYCoR@unreal \
    --to=leon@kernel.org \
    --cc=devesh.sharma@broadcom.com \
    --cc=linux-rdma@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox