public inbox for linux-rdma@vger.kernel.org
 help / color / mirror / Atom feed
From: Leon Romanovsky <leon@kernel.org>
To: Anand Khoje <anand.a.khoje@oracle.com>
Cc: linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org,
	dledford@redhat.com, jgg@ziepe.ca, haakon.bugge@oracle.com
Subject: Re: [PATCH v2 2/3] IB/core: Shuffle locks in ib_port_data to save memory
Date: Thu, 3 Jun 2021 11:55:15 +0300	[thread overview]
Message-ID: <YLiY8xeOEHseDW+8@unreal> (raw)
In-Reply-To: <20210603065024.1051-3-anand.a.khoje@oracle.com>

On Thu, Jun 03, 2021 at 12:20:23PM +0530, Anand Khoje wrote:
> pahole shows two 4-byte holes in struct ib_port_data after
> pkey_list_lock and netdev_lock respectively.
> 
> Shuffling the netdev_lock to be after pkey_list_lock, this 
> shaves off eight bytes from the struct.
> 
> Suggested-by: Haakon Bugge <haakon.bugge@oracle.com>
> Signed-off-by: Anand Khoje <anand.a.khoje@oracle.com>
> ---
>  include/rdma/ib_verbs.h | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 

Thanks,
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>

  reply	other threads:[~2021-06-03  8:55 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-03  6:50 [PATCH v2 0/3] IB/core: Obtaining subnet_prefix from cache in IB devices Anand Khoje
2021-06-03  6:50 ` [PATCH v2 1/3] IB/core: Removed port validity check from ib_get_cached_subnet_prefix Anand Khoje
2021-06-03  8:54   ` Leon Romanovsky
2021-06-03  6:50 ` [PATCH v2 2/3] IB/core: Shuffle locks in ib_port_data to save memory Anand Khoje
2021-06-03  8:55   ` Leon Romanovsky [this message]
2021-06-03  6:50 ` [PATCH v2 3/3] IB/core: Obtain subnet_prefix from cache in IB devices Anand Khoje
2021-06-03  9:07   ` Leon Romanovsky
2021-06-03  9:29     ` Haakon Bugge
2021-06-03 10:16       ` Leon Romanovsky
2021-06-03 10:36         ` Haakon Bugge
2021-06-03 12:10   ` Mark Zhang
2021-06-03 12:50     ` Haakon Bugge

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YLiY8xeOEHseDW+8@unreal \
    --to=leon@kernel.org \
    --cc=anand.a.khoje@oracle.com \
    --cc=dledford@redhat.com \
    --cc=haakon.bugge@oracle.com \
    --cc=jgg@ziepe.ca \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox