From: Leon Romanovsky <leon@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: Doug Ledford <dledford@redhat.com>,
Jason Gunthorpe <jgg@nvidia.com>,
Avihai Horon <avihaih@nvidia.com>,
linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org,
Bart Van Assche <bvanassche@acm.org>, Tom Talpey <tom@talpey.com>,
Santosh Shilimkar <santosh.shilimkar@oracle.com>,
Chuck Lever III <chuck.lever@oracle.com>,
Keith Busch <kbusch@kernel.org>,
David Laight <David.Laight@aculab.com>,
Honggang LI <honli@redhat.com>,
Max Gurtovoy <mgurtovoy@nvidia.com>
Subject: Re: [PATCH v2 rdma-next] RDMA/mlx5: Enable Relaxed Ordering by default for kernel ULPs
Date: Wed, 9 Jun 2021 16:53:23 +0300 [thread overview]
Message-ID: <YMDH05/yTtSIk9kI@unreal> (raw)
In-Reply-To: <20210609125241.GA1347@lst.de>
On Wed, Jun 09, 2021 at 02:52:41PM +0200, Christoph Hellwig wrote:
> On Wed, Jun 09, 2021 at 02:05:03PM +0300, Leon Romanovsky wrote:
> > From: Avihai Horon <avihaih@nvidia.com>
> >
> > Relaxed Ordering is a capability that can only benefit users that support
> > it. All kernel ULPs should support Relaxed Ordering, as they are designed
> > to read data only after observing the CQE and use the DMA API correctly.
> >
> > Hence, implicitly enable Relaxed Ordering by default for kernel ULPs.
> >
> > Signed-off-by: Avihai Horon <avihaih@nvidia.com>
> > Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
> > ---
> > Changelog:
> > v2:
> > * Dropped IB/core patch and set RO implicitly in mlx5 exactly like in
> > eth side of mlx5 driver.
>
> This looks great in terms of code changes. But can we please also add a
> patch to document that PCIe relaxed ordering is fine for kernel ULP usage
> somewhere?
Sure, did you have in mind some concrete place? Or will new file in the
Documentation/infiniband/ folder be good enough too?
Thanks
next prev parent reply other threads:[~2021-06-09 13:53 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-09 11:05 [PATCH v2 rdma-next] RDMA/mlx5: Enable Relaxed Ordering by default for kernel ULPs Leon Romanovsky
2021-06-09 12:52 ` Christoph Hellwig
2021-06-09 13:53 ` Leon Romanovsky [this message]
2021-06-09 13:59 ` Christoph Hellwig
2021-06-10 7:44 ` Leon Romanovsky
2021-06-09 14:10 ` David Laight
2021-06-09 14:37 ` Chuck Lever III
2021-06-09 15:05 ` David Laight
2021-06-09 15:09 ` Jason Gunthorpe
2021-06-09 15:48 ` David Laight
2021-06-21 18:02 ` Jason Gunthorpe
2021-06-21 20:20 ` Christoph Hellwig
2021-06-21 23:18 ` Jason Gunthorpe
2021-06-22 6:20 ` Leon Romanovsky
2021-06-23 23:06 ` Max Gurtovoy
2021-06-24 6:38 ` Leon Romanovsky
2021-06-24 7:39 ` Max Gurtovoy
2021-06-24 11:36 ` Jason Gunthorpe
2021-06-27 7:32 ` Leon Romanovsky
2021-06-27 7:30 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YMDH05/yTtSIk9kI@unreal \
--to=leon@kernel.org \
--cc=David.Laight@aculab.com \
--cc=avihaih@nvidia.com \
--cc=bvanassche@acm.org \
--cc=chuck.lever@oracle.com \
--cc=dledford@redhat.com \
--cc=hch@lst.de \
--cc=honli@redhat.com \
--cc=jgg@nvidia.com \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=mgurtovoy@nvidia.com \
--cc=santosh.shilimkar@oracle.com \
--cc=tom@talpey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox