From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5FDBC48BCD for ; Wed, 9 Jun 2021 13:53:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8A45261285 for ; Wed, 9 Jun 2021 13:53:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236830AbhFINzV (ORCPT ); Wed, 9 Jun 2021 09:55:21 -0400 Received: from mail.kernel.org ([198.145.29.99]:57850 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236756AbhFINzV (ORCPT ); Wed, 9 Jun 2021 09:55:21 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 6742461182; Wed, 9 Jun 2021 13:53:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1623246807; bh=ff4dV/Z38To+N3LgvFxthRICWqy7lAIQzMK8o90TLz0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Z9LlhhaezrjS96RWuxlvB34lPrzTrgB3HFhR/nN2rWzG3+eKQ3wDsOcfbBHH+AYi4 joWFOtxLR/EWF9a7PbBVQ2wcx4jB3p5IkLxM8i3S9vzbHKUNc6F/8ULX1U+2F2WmvD vif2BBIs/AKAWytfY96yOAbR5Sm7EGDmhGYxn4mW0q6R0yaqVfkL1jMG+E1lvJ41KY zhyTJq5FbaNJYkY56QD6tVRyRNcqOG2AO2lcsDQiqmMCHwZxDrTNNh6UVMoQ+fYJoE 7BCFakgISw87PGqSmSsYn3npcSlXHq7vfd2P4fQ6S6bugdyAZD5hbifEqIXsWopNVC 0TdvuWhikcarw== Date: Wed, 9 Jun 2021 16:53:23 +0300 From: Leon Romanovsky To: Christoph Hellwig Cc: Doug Ledford , Jason Gunthorpe , Avihai Horon , linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org, Bart Van Assche , Tom Talpey , Santosh Shilimkar , Chuck Lever III , Keith Busch , David Laight , Honggang LI , Max Gurtovoy Subject: Re: [PATCH v2 rdma-next] RDMA/mlx5: Enable Relaxed Ordering by default for kernel ULPs Message-ID: References: <20210609125241.GA1347@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210609125241.GA1347@lst.de> Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On Wed, Jun 09, 2021 at 02:52:41PM +0200, Christoph Hellwig wrote: > On Wed, Jun 09, 2021 at 02:05:03PM +0300, Leon Romanovsky wrote: > > From: Avihai Horon > > > > Relaxed Ordering is a capability that can only benefit users that support > > it. All kernel ULPs should support Relaxed Ordering, as they are designed > > to read data only after observing the CQE and use the DMA API correctly. > > > > Hence, implicitly enable Relaxed Ordering by default for kernel ULPs. > > > > Signed-off-by: Avihai Horon > > Signed-off-by: Leon Romanovsky > > --- > > Changelog: > > v2: > > * Dropped IB/core patch and set RO implicitly in mlx5 exactly like in > > eth side of mlx5 driver. > > This looks great in terms of code changes. But can we please also add a > patch to document that PCIe relaxed ordering is fine for kernel ULP usage > somewhere? Sure, did you have in mind some concrete place? Or will new file in the Documentation/infiniband/ folder be good enough too? Thanks