From: Leon Romanovsky <leon@kernel.org>
To: Jack Wang <jinpu.wang@ionos.com>
Cc: linux-rdma@vger.kernel.org, bvanassche@acm.org,
dledford@redhat.com, jgg@ziepe.ca, haris.iqbal@ionos.com,
Guoqing Jiang <guoqing.jiang@cloud.ionos.com>,
Md Haris Iqbal <haris.iqbal@cloud.ionos.com>,
Jack Wang <jinpu.wang@cloud.ionos.com>
Subject: Re: [PATCHv2 for-next 4/5] RDMA/rtrs: Rename some variables to avoid confusion
Date: Sun, 13 Jun 2021 09:32:24 +0300 [thread overview]
Message-ID: <YMWmeJL3QxN4d8T5@unreal> (raw)
In-Reply-To: <20210611121034.48837-5-jinpu.wang@ionos.com>
On Fri, Jun 11, 2021 at 02:10:33PM +0200, Jack Wang wrote:
> From: Guoqing Jiang <guoqing.jiang@cloud.ionos.com>
>
> Those variables are passed to create_cq, create_qp, rtrs_iu_alloc and
> rtrs_iu_free, so these *_size means the num of unit. And cq_size also
> means number of cq element.
>
> Also move the setting of cq_num to common path.
>
> Signed-off-by: Guoqing Jiang <guoqing.jiang@cloud.ionos.com>
> Reviewed-by: Md Haris Iqbal <haris.iqbal@cloud.ionos.com>
> Signed-off-by: Jack Wang <jinpu.wang@cloud.ionos.com>
> ---
> drivers/infiniband/ulp/rtrs/rtrs-clt.c | 18 +++++++++---------
> drivers/infiniband/ulp/rtrs/rtrs-clt.h | 2 +-
> drivers/infiniband/ulp/rtrs/rtrs-pri.h | 10 +++++-----
> drivers/infiniband/ulp/rtrs/rtrs-srv.c | 7 +++----
> drivers/infiniband/ulp/rtrs/rtrs.c | 24 ++++++++++++------------
> 5 files changed, 30 insertions(+), 31 deletions(-)
>
Commit message is worth to rewrite.
Thanks,
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
next prev parent reply other threads:[~2021-06-13 10:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-11 12:10 [PATCHv2 for-next 0/5] misc update for RTRS Jack Wang
2021-06-11 12:10 ` [PATCHv2 for-next 1/5] RDMA/rtrs-srv: Set minimal max_send_wr and max_recv_wr Jack Wang
2021-06-13 6:21 ` Leon Romanovsky
2021-06-11 12:10 ` [PATCHv2 for-next 2/5] RDMA/rtrs-clt: Use minimal max_send_sge when create qp Jack Wang
2021-06-13 6:23 ` Leon Romanovsky
2021-06-11 12:10 ` [PATCHv2 for-next 3/5] RDMA/rtrs: RDMA_RXE requires more number of WR Jack Wang
2021-06-13 6:25 ` Leon Romanovsky
2021-06-14 6:06 ` Jinpu Wang
2021-06-11 12:10 ` [PATCHv2 for-next 4/5] RDMA/rtrs: Rename some variables to avoid confusion Jack Wang
2021-06-13 6:32 ` Leon Romanovsky [this message]
2021-06-11 12:10 ` [PATCHv2 for-next 5/5] RDMA/rtrs: Check device max_qp_wr limit when create QP Jack Wang
2021-06-13 6:36 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YMWmeJL3QxN4d8T5@unreal \
--to=leon@kernel.org \
--cc=bvanassche@acm.org \
--cc=dledford@redhat.com \
--cc=guoqing.jiang@cloud.ionos.com \
--cc=haris.iqbal@cloud.ionos.com \
--cc=haris.iqbal@ionos.com \
--cc=jgg@ziepe.ca \
--cc=jinpu.wang@cloud.ionos.com \
--cc=jinpu.wang@ionos.com \
--cc=linux-rdma@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox