From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.6 required=3.0 tests=BAYES_00,DATE_IN_PAST_03_06, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99C39C48BDF for ; Sun, 13 Jun 2021 10:12:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7EECF610C8 for ; Sun, 13 Jun 2021 10:12:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231576AbhFMKOk (ORCPT ); Sun, 13 Jun 2021 06:14:40 -0400 Received: from mail.kernel.org ([198.145.29.99]:57542 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231277AbhFMKOk (ORCPT ); Sun, 13 Jun 2021 06:14:40 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id D988B6124C; Sun, 13 Jun 2021 10:12:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1623579159; bh=vxEF0q7emP1WZlaczjGF+kqJuzgeKNNCd72MFYG7DYY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Gd4tzTx3XNy5aEAjIXQ5YdMbl4BKSli+buaptUeKk0wcPyh7VYPID6t/n2WQ1tTHf 8xiIxYLeuFVRq9tLqanUg9iGerOe8MXV/Mqx10iSuMNEVVCsw7v5PjMNTL0xuga/Lb AOWnnUB7OPv6KJfdV9wPqSALhmuSwxm49RzcXflg1Ok51MwesK7uBHQoN2tAWL9UJv AwR7HqIdMVWPUlrmriuL3wxJ9+YNX9ojIPwjI3DarTh8r0/hZ1U77gFh3Yv2dUvLkK qsM8MxM+pRX4LC4tHlMiAEv8m5pv/BnPEJFCGfW1sUk1aNxmJU8wZoDDhvApyLiKUU S+gHLkeQMHTXA== Date: Sun, 13 Jun 2021 09:36:50 +0300 From: Leon Romanovsky To: Jack Wang Cc: linux-rdma@vger.kernel.org, bvanassche@acm.org, dledford@redhat.com, jgg@ziepe.ca, haris.iqbal@ionos.com, Gioh Kim Subject: Re: [PATCHv2 for-next 5/5] RDMA/rtrs: Check device max_qp_wr limit when create QP Message-ID: References: <20210611121034.48837-1-jinpu.wang@ionos.com> <20210611121034.48837-6-jinpu.wang@ionos.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210611121034.48837-6-jinpu.wang@ionos.com> Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On Fri, Jun 11, 2021 at 02:10:34PM +0200, Jack Wang wrote: > Currently we only check device max_qp_wr limit for IO connection, > but not for service connection. We should check for both. > > So save the max_qp_wr device limit in wr_limit, and use it for both > IO connections and service connections. > > While at it, also remove an outdated comments. > > Suggested-by: Leon Romanovsky > Signed-off-by: Jack Wang > Signed-off-by: Gioh Kim > --- > drivers/infiniband/ulp/rtrs/rtrs-clt.c | 29 +++++++++++++------------- > drivers/infiniband/ulp/rtrs/rtrs-srv.c | 13 ++++-------- > 2 files changed, 19 insertions(+), 23 deletions(-) > Thanks, Reviewed-by: Leon Romanovsky