From: Leon Romanovsky <leon@kernel.org>
To: "Håkon Bugge" <haakon.bugge@oracle.com>
Cc: Doug Ledford <dledford@redhat.com>,
Jason Gunthorpe <jgg@nvidia.com>,
linux-rdma@vger.kernel.org,
Hans Westgaard Ry <hans.westgaard.ry@oracle.com>
Subject: Re: [PATCH for-next] RDMA/cma: Fix incorrect Packet Lifetime calculation
Date: Tue, 22 Jun 2021 11:18:22 +0300 [thread overview]
Message-ID: <YNGcznXKXn2+izJX@unreal> (raw)
In-Reply-To: <1624281537-5573-1-git-send-email-haakon.bugge@oracle.com>
On Mon, Jun 21, 2021 at 03:18:57PM +0200, Håkon Bugge wrote:
> An approximation for the PacketLifeTime is half the local ACK timeout.
> The encoding for both timers are logarithmic. The PacketLifeTime
> calculation is wrong when local ACK timeout is zero. In that case,
> PacketLifeTime is set to the incorrect value 255.
>
> Fixed by explicitly testing for timeout being zero.
>
> Fixes: e1ee1e62bec4 ("RDMA/cma: Use ACK timeout for RoCE packetLifeTime")
> Signed-off-by: Håkon Bugge <haakon.bugge@oracle.com>
>
> ---
>
> * Note: This commit must be merged after ("RDMA/cma: Replace
> RMW with atomic bit-ops")
> ---
> drivers/infiniband/core/cma.c | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
Thanks,
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
next prev parent reply other threads:[~2021-06-22 8:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-21 13:18 [PATCH for-next] RDMA/cma: Fix incorrect Packet Lifetime calculation Håkon Bugge
2021-06-22 8:18 ` Leon Romanovsky [this message]
2021-06-22 9:32 ` Haakon Bugge
2021-06-22 12:17 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YNGcznXKXn2+izJX@unreal \
--to=leon@kernel.org \
--cc=dledford@redhat.com \
--cc=haakon.bugge@oracle.com \
--cc=hans.westgaard.ry@oracle.com \
--cc=jgg@nvidia.com \
--cc=linux-rdma@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox