From: Leon Romanovsky <leon@kernel.org>
To: Bob Pearson <rpearsonhpe@gmail.com>
Cc: jgg@nvidia.com, zyjzyj2000@gmail.com, linux-rdma@vger.kernel.org
Subject: Re: [PATCH for-next] RDMA/rxe: Let rdma-core manage PDs
Date: Tue, 27 Jul 2021 15:02:57 +0300 [thread overview]
Message-ID: <YP/18Ycu+EMLA8T8@unreal> (raw)
In-Reply-To: <c181c1b9-a2a6-3cf0-8644-762f6398bb5e@gmail.com>
On Tue, Jul 27, 2021 at 06:31:59AM -0500, Bob Pearson wrote:
> On 7/27/21 6:30 AM, Leon Romanovsky wrote:
> > On Mon, Jul 26, 2021 at 04:58:16PM -0500, Bob Pearson wrote:
> >> Currently several rxe objects hold references to PDs which are ref-
> >> counted. This replicates work already done by RDMA core which takes
> >> references to PDs in the ib objects which are contained in the rxe
> >> objects. This patch removes struct rxe_pd from rxe objects and removes
> >> reference counting for PDs except for PD alloc and PD dealloc. It also
> >> adds inline extractor routines which return PDs from the PDs in the
> >> ib objects. The names of these are made consistent including a rxe_
> >> prefix.
> >>
> >> Signed-off-by: Bob Pearson <rpearsonhpe@gmail.com>
> >> ---
> >> drivers/infiniband/sw/rxe/rxe_comp.c | 4 ++--
> >> drivers/infiniband/sw/rxe/rxe_loc.h | 4 ++--
> >> drivers/infiniband/sw/rxe/rxe_mr.c | 8 +++----
> >> drivers/infiniband/sw/rxe/rxe_mw.c | 31 +++++++++++----------------
> >> drivers/infiniband/sw/rxe/rxe_qp.c | 9 +-------
> >> drivers/infiniband/sw/rxe/rxe_req.c | 2 +-
> >> drivers/infiniband/sw/rxe/rxe_resp.c | 4 ++--
> >> drivers/infiniband/sw/rxe/rxe_verbs.c | 26 ++++++----------------
> >> drivers/infiniband/sw/rxe/rxe_verbs.h | 24 +++++++++++++++------
> >> 9 files changed, 48 insertions(+), 64 deletions(-)
> >
> > Last time when I looked on it, I came to conclusion that all RXE
> > references can be dropped.
> >
> > Thanks
> >
> This is a step in that direction. There are more coming.
Glad to hear, thank you for your work.
> Regards,
>
> Bob
next prev parent reply other threads:[~2021-07-27 12:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-26 21:58 [PATCH for-next] RDMA/rxe: Let rdma-core manage PDs Bob Pearson
2021-07-27 11:30 ` Leon Romanovsky
2021-07-27 11:31 ` Bob Pearson
2021-07-27 12:02 ` Leon Romanovsky [this message]
2021-07-27 12:44 ` Bob Pearson
2021-07-27 12:58 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YP/18Ycu+EMLA8T8@unreal \
--to=leon@kernel.org \
--cc=jgg@nvidia.com \
--cc=linux-rdma@vger.kernel.org \
--cc=rpearsonhpe@gmail.com \
--cc=zyjzyj2000@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox