public inbox for linux-rdma@vger.kernel.org
 help / color / mirror / Atom feed
From: Leon Romanovsky <leon@kernel.org>
To: Shai Malin <smalin@marvell.com>
Cc: linux-rdma@vger.kernel.org, dledford@redhat.com, jgg@nvidia.com,
	mkalderon@marvell.com, davem@davemloft.net, kuba@kernel.org,
	aelior@marvell.com, pkushwaha@marvell.com,
	prabhakar.pkin@gmail.com, malin1024@gmail.com
Subject: Re: [PATCH for-next 1/3] qed: add get and set support for dscp priority
Date: Thu, 29 Jul 2021 20:21:38 +0300	[thread overview]
Message-ID: <YQLjosQBfa9JDPf6@unreal> (raw)
In-Reply-To: <20210729133032.26278-2-smalin@marvell.com>

On Thu, Jul 29, 2021 at 04:30:30PM +0300, Shai Malin wrote:
> From: Prabhakar Kushwaha <pkushwaha@marvell.com>
> 
> This patch add support of get or set priority value for a given
> dscp index.
> 
> Signed-off-by: Shai Malin <smalin@marvell.com>
> Signed-off-by: Ariel Elior <aelior@marvell.com>
> Signed-off-by: Prabhakar Kushwaha <pkushwaha@marvell.com>
> ---
>  drivers/net/ethernet/qlogic/qed/qed_dcbx.c | 65 ++++++++++++++++++++++
>  drivers/net/ethernet/qlogic/qed/qed_dcbx.h |  9 +++
>  include/linux/qed/qed_if.h                 |  6 ++
>  3 files changed, 80 insertions(+)
> 
> diff --git a/drivers/net/ethernet/qlogic/qed/qed_dcbx.c b/drivers/net/ethernet/qlogic/qed/qed_dcbx.c
> index e81dd34a3cac..ba9276599e72 100644
> --- a/drivers/net/ethernet/qlogic/qed/qed_dcbx.c
> +++ b/drivers/net/ethernet/qlogic/qed/qed_dcbx.c
> @@ -1280,6 +1280,71 @@ int qed_dcbx_get_config_params(struct qed_hwfn *p_hwfn,
>  	return 0;
>  }

<...>

> +	p_dcbx_info = kmalloc(sizeof(*p_dcbx_info), GFP_KERNEL);
> +	if (!p_dcbx_info)
> +		return -ENOMEM;
> +
> +	memset(p_dcbx_info, 0, sizeof(*p_dcbx_info));

This is open-coded kzalloc().

Thanks

  reply	other threads:[~2021-07-29 17:21 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-29 13:30 [PATCH for-next 0/3] qedr: consider dscp prio for vlan tag and update tos Shai Malin
2021-07-29 13:30 ` [PATCH for-next 1/3] qed: add get and set support for dscp priority Shai Malin
2021-07-29 17:21   ` Leon Romanovsky [this message]
2021-07-29 13:30 ` [PATCH for-next 2/3] qedr: Consider dscp priority for vlan priority Shai Malin
2021-07-29 13:30 ` [PATCH for-next 3/3] qedr: Use grh layer traffic_class as RDMA CM TOS Shai Malin
  -- strict thread matches above, loose matches on Subject: below --
2021-07-30  6:46 [PATCH for-next 1/3] qed: add get and set support for dscp priority Shai Malin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YQLjosQBfa9JDPf6@unreal \
    --to=leon@kernel.org \
    --cc=aelior@marvell.com \
    --cc=davem@davemloft.net \
    --cc=dledford@redhat.com \
    --cc=jgg@nvidia.com \
    --cc=kuba@kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=malin1024@gmail.com \
    --cc=mkalderon@marvell.com \
    --cc=pkushwaha@marvell.com \
    --cc=prabhakar.pkin@gmail.com \
    --cc=smalin@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox