From: Leon Romanovsky <leon@kernel.org>
To: Bob Pearson <rpearsonhpe@gmail.com>
Cc: linux-rdma@vger.kernel.org, zyjzyj2000@gmail.com, jgg@nvidia.com
Subject: Re: [PATCH] Provider/rxe: Remove printf()
Date: Thu, 30 Sep 2021 08:18:57 +0300 [thread overview]
Message-ID: <YVVIwUBwvr9AGHtC@unreal> (raw)
In-Reply-To: <20210929214214.18767-1-rpearsonhpe@gmail.com>
On Wed, Sep 29, 2021 at 04:42:15PM -0500, Bob Pearson wrote:
> Currently the rxe provider issues a print statement if it detects
> an invalid work request and also returns an error. A recently
> added python test case triggers such a message which is expected
> since the test is deliberately constructing invalid work requests.
>
> This patch removes the print statement which has no practical use.
>
> Signed-off-by: Bob Pearson <rpearsonhpe@gmail.com>
> ---
> providers/rxe/rxe.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
Please remove this "fprintf(stderr, "rxe: Failed to query sgid.\n");"
line too.
Thanks
>
> diff --git a/providers/rxe/rxe.c b/providers/rxe/rxe.c
> index 3533a325..42fc447c 100644
> --- a/providers/rxe/rxe.c
> +++ b/providers/rxe/rxe.c
> @@ -1513,10 +1513,8 @@ static int post_one_send(struct rxe_qp *qp, struct rxe_wq *sq,
> length += ibwr->sg_list[i].length;
>
> err = validate_send_wr(qp, ibwr, length);
> - if (err) {
> - printf("validate send failed\n");
> + if (err)
> return err;
> - }
>
> wqe = (struct rxe_send_wqe *)producer_addr(sq->queue);
>
> --
> 2.30.2
>
next prev parent reply other threads:[~2021-09-30 5:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-29 21:42 [PATCH] Provider/rxe: Remove printf() Bob Pearson
2021-09-30 5:18 ` Leon Romanovsky [this message]
2021-09-30 20:05 ` Bob Pearson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YVVIwUBwvr9AGHtC@unreal \
--to=leon@kernel.org \
--cc=jgg@nvidia.com \
--cc=linux-rdma@vger.kernel.org \
--cc=rpearsonhpe@gmail.com \
--cc=zyjzyj2000@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox