From: Leon Romanovsky <leon@kernel.org>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: dledford@redhat.com, jgg@ziepe.ca, bharat@chelsio.com,
yishaih@nvidia.com, bmt@zurich.ibm.com,
linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] RDMA: Remove redundant 'flush_workqueue()' calls
Date: Tue, 12 Oct 2021 09:23:14 +0300 [thread overview]
Message-ID: <YWUp0s6TD6R1cse8@unreal> (raw)
In-Reply-To: <ca7bac6e6c9c5cc8d04eec3944edb13de0e381a3.1633874776.git.christophe.jaillet@wanadoo.fr>
On Sun, Oct 10, 2021 at 04:08:10PM +0200, Christophe JAILLET wrote:
> 'destroy_workqueue()' already drains the queue before destroying it, so
> there is no need to flush it explicitly.
>
> Remove the redundant 'flush_workqueue()' calls.
>
> This was generated with coccinelle:
>
> @@
> expression E;
> @@
> - flush_workqueue(E);
> destroy_workqueue(E);
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> drivers/infiniband/core/sa_query.c | 1 -
> drivers/infiniband/hw/cxgb4/cm.c | 1 -
> drivers/infiniband/hw/cxgb4/device.c | 1 -
> drivers/infiniband/hw/mlx4/alias_GUID.c | 4 +---
> drivers/infiniband/sw/siw/siw_cm.c | 4 +---
> drivers/infiniband/ulp/ipoib/ipoib_main.c | 1 -
> 6 files changed, 2 insertions(+), 10 deletions(-)
>
Thanks,
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
next prev parent reply other threads:[~2021-10-12 6:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-10 14:08 [PATCH] RDMA: Remove redundant 'flush_workqueue()' calls Christophe JAILLET
2021-10-12 6:23 ` Leon Romanovsky [this message]
2021-10-12 16:20 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YWUp0s6TD6R1cse8@unreal \
--to=leon@kernel.org \
--cc=bharat@chelsio.com \
--cc=bmt@zurich.ibm.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=dledford@redhat.com \
--cc=jgg@ziepe.ca \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=yishaih@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).