Re: [PATCH v2 rdma-core 1/2] Update kernel headers

[Leon Romanovsky <leon@kernel.org>]

On Tue, Nov 16, 2021 at 11:31:00PM +0800, Wenpeng Liang wrote:
> 
> On 2021/11/16 23:03, Wenpeng Liang wrote:
> > To commit ?? ("RDMA/hns: Support direct wqe of userspace").
> > 
> > Signed-off-by: Wenpeng Liang <liangwenpeng@huawei.com>
> > ---
> >  kernel-headers/rdma/hns-abi.h       |  2 ++
> >  kernel-headers/rdma/rdma_netlink.h  |  5 +++++
> >  kernel-headers/rdma/rdma_user_rxe.h | 14 +++++++++++---
> >  3 files changed, 18 insertions(+), 3 deletions(-)
> 
> Hi Leon,
> 
> I have encountered a problem and I hope to master a correct
> submission method.
> 
> This user space patch modifies the hns-abi.h file, so I use the
> python command to generate the patch to keep the kernel-headers
> consistent with the kernel mode:
> 
> python3.5 kernel-headers/update --not-final <kernel space dir> <commitID>
> 
> In addition to the modification of hns-abi.h, the generated patch
> also involves the modification of other files. And resulted in the
> following compilation error:
> 
> /rdma-core/providers/rxe/rxe.c: In function ‘rxe_post_one_recv’:
> /rdma-core/providers/rxe/rxe.c:712:17: error: ‘struct rxe_dma_info’ has no member named ‘sge’
>    712 | memcpy(wqe->dma.sge, recv_wr->sg_list,
>        | ^
> /rdma-core/providers/rxe/rxe.c:713:38: error: ‘struct rxe_dma_info’ has no member named ‘sge’
>    713 | wqe->num_sge*sizeof(*wqe->dma.sge));
> 
> In this case, what is the correct way to submit the patch? Should
> I wait for the rxe patch submission to complete before submitting
> this patchset, or submit only the hns part of the patch generated
> by python?

Please wait a couple of days, we will fix Jason's PR and I will release
rdma-core, so you will be able to submit without errors.

Thanks

> 
> Thanks,
> Wenpeng