From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 583E5C433EF for ; Mon, 3 Jan 2022 09:47:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231234AbiACJrV (ORCPT ); Mon, 3 Jan 2022 04:47:21 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33094 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231142AbiACJrV (ORCPT ); Mon, 3 Jan 2022 04:47:21 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 12273C061761 for ; Mon, 3 Jan 2022 01:47:21 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id D1687B80989 for ; Mon, 3 Jan 2022 09:47:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D5B50C36AE9; Mon, 3 Jan 2022 09:47:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1641203238; bh=x5PqyJ9tAB+q8nGgwTmhxzy8Y6csC5RHIjggvZym2lI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fG5fpXGT3vRXGkoEmTMGrTQwq5ed2C6E27EhdkdpfH2EKbyUkuSy8mIt6I2u4Hoj/ SPDYHLVrVoiwOFWsrqTMmpWPB57iIZSg2w/XoAfga66mQ9QmlWrRax+ey+L3MtThCD jaQGX2SPV0E3UjQQ6Cj2VsWeysdUCZC7j1HYBQFaLSBy1H+trUXckJFolixcoOErhw KEhBSbsn8sW4UeDmWOSj/9aXjqCdw6BJo6bw5X0AVBkuSctvgrdca8toQjcdkTHpKh 9KUf3CApdee4NkLi978QoF8GdCa8qxTTv7D76RNUBS9Q/ObWfhcTJQs0O6d+y4csNg 2GAUohWdHxeSA== Date: Mon, 3 Jan 2022 11:47:14 +0200 From: Leon Romanovsky To: yanjun.zhu@linux.dev Cc: mustafa.ismail@intel.com, shiraz.saleem@intel.com, jgg@ziepe.ca, linux-rdma@vger.kernel.org Subject: Re: [PATCHv3 1/1] RDMA/irdma: Make the source udp port vary Message-ID: References: <20211221173913.1386261-1-yanjun.zhu@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211221173913.1386261-1-yanjun.zhu@linux.dev> Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On Tue, Dec 21, 2021 at 12:39:13PM -0500, yanjun.zhu@linux.dev wrote: > From: Zhu Yanjun > > Based on the link https://www.spinics.net/lists/linux-rdma/msg73735.html, Please use lore.kernel.org links. They have all chances to outlive spinics. > get the source udp port number for a QP based on the grh.flow_label or > lqpn/rqrpn. This provides a better spread of traffic across NIC RX queues. > The method in the commit 2b880b2e5e03 ("RDMA/mlx5: Define RoCEv2 udp > source port when set path") is a standard way. So it is also adopted in > this commit. > > Signed-off-by: Zhu Yanjun > --- > V2->V3: Move to the block of IB_QP_AV in the mask and IB_AH_GRH in ah_flags > V1->V2: Adopt a standard method to get udp source port. > --- > drivers/infiniband/hw/irdma/verbs.c | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/drivers/infiniband/hw/irdma/verbs.c b/drivers/infiniband/hw/irdma/verbs.c > index 8cd5f9261692..31039b295206 100644 > --- a/drivers/infiniband/hw/irdma/verbs.c > +++ b/drivers/infiniband/hw/irdma/verbs.c > @@ -1094,6 +1094,15 @@ static int irdma_query_pkey(struct ib_device *ibdev, u32 port, u16 index, > return 0; > } > > + > +static u16 irdma_get_udp_sport(u32 fl, u32 lqpn, u32 rqpn) > +{ > + if (!fl) > + fl = rdma_calc_flow_label(lqpn, rqpn); > + > + return rdma_flow_label_to_udp_sport(fl); > +} > + > /** > * irdma_modify_qp_roce - modify qp request > * @ibqp: qp's pointer for modify > @@ -1167,6 +1176,11 @@ int irdma_modify_qp_roce(struct ib_qp *ibqp, struct ib_qp_attr *attr, > > memset(&iwqp->roce_ah, 0, sizeof(iwqp->roce_ah)); > if (attr->ah_attr.ah_flags & IB_AH_GRH) { > + u32 fl = udp_info->flow_label; > + u32 lqp = ibqp->qp_num; > + u32 rqp = roce_info->dest_qp; > + I don't see too much value in these extra variables and extra function that is the same as get_udp_sport() from hns. It is worth to add new function to ib_verbs.h and reuse in both drivers. Thanks > + udp_info->src_port = irdma_get_udp_sport(fl, lqp, rqp); > udp_info->ttl = attr->ah_attr.grh.hop_limit; > udp_info->flow_label = attr->ah_attr.grh.flow_label; > udp_info->tos = attr->ah_attr.grh.traffic_class; > -- > 2.27.0 >