From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58266C433F5 for ; Sun, 9 Jan 2022 12:22:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235496AbiAIMWL (ORCPT ); Sun, 9 Jan 2022 07:22:11 -0500 Received: from ams.source.kernel.org ([145.40.68.75]:58442 "EHLO ams.source.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235494AbiAIMWL (ORCPT ); Sun, 9 Jan 2022 07:22:11 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 1D03EB80BAA; Sun, 9 Jan 2022 12:22:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E9837C36AED; Sun, 9 Jan 2022 12:22:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1641730928; bh=9Gyfy4j0o8s7FwlSNpFnI0PGz6sjtHeXD/kujBYgvws=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ic7neLbIZ5h6ZotjVOU4gGHqVpUmgwW3WexDuFvDXNcRDnwfvHYMLTqd5rSFBAxMB iQPda1DXGBpAiSeevSr8NKcNngy5f85hI3S91Rzcvl0jodWmUBBwIADY6UCV0pL2oU N/c/AjXzxCISJ8S4n5ROonej/MLH2IynhiCCd9Y5/7hQXeMdyv/K7xnGkLWyZn7VXh VfUVpih3MHJlttuuNxcU52exTAkqtm3rBwE7briiOUb3cxtV82seM3U5XKeoQCnsH4 d1poe27NpFAfyVUOfJpLjjwoERQDxPuAIfNZBdnnbgo/2xz8mnVb/D2dMwK0YiRsPL +tUTsudAZQAaw== Date: Sun, 9 Jan 2022 14:22:04 +0200 From: Leon Romanovsky To: Jason Gunthorpe Cc: linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org, syzbot+8fcbb77276d43cc8b693@syzkaller.appspotmail.com Subject: Re: [PATCH rdma-rc] RDMA/cma: Clear all multicast request fields Message-ID: References: <1876bacbbcb6f82af3948e5c37a09da6ea3fcae5.1641474841.git.leonro@nvidia.com> <20220106173941.GA2963550@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220106173941.GA2963550@nvidia.com> Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On Thu, Jan 06, 2022 at 01:39:41PM -0400, Jason Gunthorpe wrote: > On Thu, Jan 06, 2022 at 03:15:07PM +0200, Leon Romanovsky wrote: > > From: Leon Romanovsky > > > > The ib->rec.qkey field is accessed without being initialized. > > Clear the ib_sa_multicast struct to fix the following syzkaller error/. > > > > ===================================================== > > BUG: KMSAN: uninit-value in cma_set_qkey drivers/infiniband/core/cma.c:510 [inline] > > BUG: KMSAN: uninit-value in cma_make_mc_event+0xb73/0xe00 drivers/infiniband/core/cma.c:4570 > > cma_set_qkey drivers/infiniband/core/cma.c:510 [inline] > > cma_make_mc_event+0xb73/0xe00 drivers/infiniband/core/cma.c:4570 > > cma_iboe_join_multicast drivers/infiniband/core/cma.c:4782 [inline] > > rdma_join_multicast+0x2b83/0x30a0 drivers/infiniband/core/cma.c:4814 > > ucma_process_join+0xa76/0xf60 drivers/infiniband/core/ucma.c:1479 > > ucma_join_multicast+0x1e3/0x250 drivers/infiniband/core/ucma.c:1546 > > ucma_write+0x639/0x6d0 drivers/infiniband/core/ucma.c:1732 > > vfs_write+0x8ce/0x2030 fs/read_write.c:588 > > ksys_write+0x28c/0x520 fs/read_write.c:643 > > __do_sys_write fs/read_write.c:655 [inline] > > __se_sys_write fs/read_write.c:652 [inline] > > __ia32_sys_write+0xdb/0x120 fs/read_write.c:652 > > do_syscall_32_irqs_on arch/x86/entry/common.c:114 [inline] > > __do_fast_syscall_32+0x96/0xf0 arch/x86/entry/common.c:180 > > do_fast_syscall_32+0x34/0x70 arch/x86/entry/common.c:205 > > do_SYSENTER_32+0x1b/0x20 arch/x86/entry/common.c:248 > > entry_SYSENTER_compat_after_hwframe+0x4d/0x5c > > > > Local variable ib.i created at: > > cma_iboe_join_multicast drivers/infiniband/core/cma.c:4737 [inline] > > rdma_join_multicast+0x586/0x30a0 drivers/infiniband/core/cma.c:4814 > > ucma_process_join+0xa76/0xf60 drivers/infiniband/core/ucma.c:1479 > > > > CPU: 0 PID: 29874 Comm: syz-executor.3 Not tainted 5.16.0-rc3-syzkaller #0 > > Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011 > > ===================================================== > > > > Fixes: b5de0c60cc30 ("RDMA/cma: Fix use after free race in roce multicast join") > > Reported-by: syzbot+8fcbb77276d43cc8b693@syzkaller.appspotmail.com > > Signed-off-by: Leon Romanovsky > > drivers/infiniband/core/cma.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/infiniband/core/cma.c b/drivers/infiniband/core/cma.c > > index 69c9a12dd14e..9c53e1e7de50 100644 > > +++ b/drivers/infiniband/core/cma.c > > @@ -4737,7 +4737,7 @@ static int cma_iboe_join_multicast(struct rdma_id_private *id_priv, > > int err = 0; > > struct sockaddr *addr = (struct sockaddr *)&mc->addr; > > struct net_device *ndev = NULL; > > - struct ib_sa_multicast ib; > > + struct ib_sa_multicast ib = {}; > > enum ib_gid_type gid_type; > > bool send_only; > > We shouldn't be able to join anything except a RDMA_PS_UDP to a > multicast in the first place: > > if (id_priv->id.ps == RDMA_PS_UDP) > ib.rec.qkey = cpu_to_be32(RDMA_UDP_QKEY); > > Multicast RC/etc is meaningless. So I guess it should be like this: I don't know, I used 0 exactly like we have for cma_join_ib_multicast(). Where can I read about this PS limitation? I didn't find anything relevant in the IBTA spec. Thanks