From: Leon Romanovsky <leon@kernel.org>
To: Xiao Yang <yangx.jy@fujitsu.com>
Cc: linux-rdma@vger.kernel.org, rpearsonhpe@gmail.com, jgg@ziepe.ca
Subject: Re: [PATCH rdma-core v2] providers/rxe: Replace '%' with '&' in check_qp_queue_full()
Date: Sun, 23 Jan 2022 13:04:11 +0200 [thread overview]
Message-ID: <Ye02K3ehx5Zw9aya@unreal> (raw)
In-Reply-To: <20220121062222.2914007-1-yangx.jy@fujitsu.com>
On Fri, Jan 21, 2022 at 02:22:22PM +0800, Xiao Yang wrote:
> The expression "cons == ((qp->cur_index + 1) % q->index_mask)" doesn't
> check the state of queue (full or empty) correctly. For example:
> If cons and qp->cur_index are 0 and q->index_mask is 1, the queue is actually
> empty but check_qp_queue_full() reports full (ENOSPC).
>
> Fixes: 1a894ca10105 ("Providers/rxe: Implement ibv_create_qp_ex verb")
> Signed-off-by: Xiao Yang <yangx.jy@fujitsu.com>
> ---
> providers/rxe/rxe_queue.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Thanks, applied.
prev parent reply other threads:[~2022-01-23 11:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-21 6:22 [PATCH rdma-core v2] providers/rxe: Replace '%' with '&' in check_qp_queue_full() Xiao Yang
2022-01-21 6:47 ` Bob Pearson
2022-01-23 11:04 ` Leon Romanovsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ye02K3ehx5Zw9aya@unreal \
--to=leon@kernel.org \
--cc=jgg@ziepe.ca \
--cc=linux-rdma@vger.kernel.org \
--cc=rpearsonhpe@gmail.com \
--cc=yangx.jy@fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox