From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1865C433FE for ; Thu, 27 Jan 2022 07:59:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237495AbiA0H7l (ORCPT ); Thu, 27 Jan 2022 02:59:41 -0500 Received: from out199-4.us.a.mail.aliyun.com ([47.90.199.4]:43371 "EHLO out199-4.us.a.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229724AbiA0H7k (ORCPT ); Thu, 27 Jan 2022 02:59:40 -0500 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R101e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04395;MF=tonylu@linux.alibaba.com;NM=1;PH=DS;RN=8;SR=0;TI=SMTPD_---0V2zDTm1_1643270376; Received: from localhost(mailfrom:tonylu@linux.alibaba.com fp:SMTPD_---0V2zDTm1_1643270376) by smtp.aliyun-inc.com(127.0.0.1); Thu, 27 Jan 2022 15:59:37 +0800 Date: Thu, 27 Jan 2022 15:59:36 +0800 From: Tony Lu To: Leon Romanovsky Cc: Jason Gunthorpe , kgraul@linux.ibm.com, kuba@kernel.org, davem@davemloft.net, netdev@vger.kernel.org, linux-s390@vger.kernel.org, RDMA mailing list Subject: Re: [RFC PATCH net-next 0/6] net/smc: Spread workload over multiple cores Message-ID: Reply-To: Tony Lu References: <20220114054852.38058-1-tonylu@linux.alibaba.com> <20220126152806.GN8034@ziepe.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On Thu, Jan 27, 2022 at 08:21:07AM +0200, Leon Romanovsky wrote: > On Thu, Jan 27, 2022 at 11:14:37AM +0800, Tony Lu wrote: > > On Wed, Jan 26, 2022 at 11:28:06AM -0400, Jason Gunthorpe wrote: > > > On Wed, Jan 26, 2022 at 03:23:22PM +0800, Tony Lu wrote: > > > > On Sun, Jan 16, 2022 at 11:00:33AM +0200, Leon Romanovsky wrote: > > > > > > > > > > Please CC RDMA mailing list next time. > > > > > > > > > > Why didn't you use already existed APIs in drivers/infiniband/core/cq.c? > > > > > ib_cq_pool_get() will do most if not all of your open-coded CQ spreading > > > > > logic. > > > > > > > > I am working on replacing with ib_cq_pool_get(), this need ib_poll_context > > > > to indicate the poller which provides by ib_poll_handler(). It's okay > > > > for now, but for the callback function. When it polled a ib_wc, it > > > > would call wc->wr_cqe->done(cq, wc), which is the union with wr_id. The > > > > wr_id is heavily used in SMC. > > > > > > Part of using the new interface is converting to use wr_cqe, you > > > should just do that work instead of trying to duplicate a core API in > > > a driver. > > > > Thanks for your advice. This patch set aims to improve performance with > > current API in SMC protocol, which is more urgent. > > This code existed from 2017, it is hard to agree with "urgent" claim. Yes, I agree with you that the code is old. I think there are two problems, one for performance issue, the other one for API refactor. We are running into the performance issues mentioned in patches in our cloud environment. So I think it is more urgent for a real world issue. The current modification is less intrusive to the code. This makes changes simpler. And current implement works for now, this is why I put refactor behind. Thank you, Tony Lu