From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52A3BC433EF for ; Tue, 26 Jul 2022 05:36:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231258AbiGZFg6 (ORCPT ); Tue, 26 Jul 2022 01:36:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40328 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230094AbiGZFg5 (ORCPT ); Tue, 26 Jul 2022 01:36:57 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 193B724BC1; Mon, 25 Jul 2022 22:36:56 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id C0872B811C3; Tue, 26 Jul 2022 05:36:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A6285C341C0; Tue, 26 Jul 2022 05:36:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1658813813; bh=swMWmdHL2Ht/begBedL2i8axCFmjIsGE43WtSM3VEwc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=UFQoBr1ZlYmecGiK08zByV8yHS1PrBIFvHrLq3eaE6ZcIvCrdQshW8q60qhf0ND6A 5GmUgHLcPaX01nMT8soeeS2qoIQpwXJ2CPw/p45NwN3XrYud2OuBQYfuxVDCVZm0C7 m6vlnp0yseYGE+GAplwq3wNgwz/hp3edrmuRqooqjsBN4p77LbokNk3XhCx+uNdw1v ffsFYXTGYcHjETLEwsapuH20gHCi26g96eiVacrzPwT+XOX1NXUdKi2kfv0wyTXHyL +FcIunqL7h6hWyEsaaEphZjzYGmaB3JZJxAKwPBTkTINb48/zDiPXftOwhB1v9trL3 yNpMCDLt551yg== Date: Tue, 26 Jul 2022 08:36:48 +0300 From: Leon Romanovsky To: Ajit Khaparde Cc: Michael Chan , davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, jgg@ziepe.ca, Selvin Xavier , linux-rdma@vger.kernel.org, Andrew Gospodarek Subject: Re: [PATCH 2/2] RDMA/bnxt_re: Use auxiliary driver interface Message-ID: References: <20220724231458.93830-1-ajit.khaparde@broadcom.com> <20220724231458.93830-3-ajit.khaparde@broadcom.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On Mon, Jul 25, 2022 at 09:58:30PM -0700, Ajit Khaparde wrote: > On Mon, Jul 25, 2022 at 5:15 AM Leon Romanovsky wrote: > > > > On Sun, Jul 24, 2022 at 04:14:58PM -0700, Ajit Khaparde wrote: > > > Use auxiliary driver interface for driver load, unload ROCE driver. > > > The driver does not need to register the interface using the netdev > > > notifier anymore. Removed the bnxt_re_dev_list which is not needed. > > > Currently probe, remove and shutdown ops have been implemented for > > > the auxiliary device. > > > > > > BUG: DCSG01157556 > > > Change-Id: Ice54f076c1c4fc26d4ee7e77a5dcd1ca21cf4cd0 > > > > Please remove the lines above. > Apologies for missing that. > > > > > > Signed-off-by: Ajit Khaparde > > > --- > > > drivers/infiniband/hw/bnxt_re/bnxt_re.h | 9 +- > > > drivers/infiniband/hw/bnxt_re/main.c | 405 +++++++----------- > > > drivers/net/ethernet/broadcom/bnxt/bnxt.c | 64 --- > > > drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.c | 65 +++ > > > drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.h | 3 + > > > 5 files changed, 232 insertions(+), 314 deletions(-) > > > > <...> > > > > > +static DEFINE_IDA(bnxt_aux_dev_ids); > > > + > > > static int bnxt_register_dev(struct bnxt_en_dev *edev, unsigned int ulp_id, > > > struct bnxt_ulp_ops *ulp_ops, void *handle) > > > > I would expect that almost all code in bnxt_ulp.c will go after this change. > I agree. My plan was to get these QA tested, initial Aux Bus changes > in this release with a follow on series to clean this up further. > Does that sound reasonable? No, please prepare complete series and we will review it. There is much harder to do it when the change is partial. Thanks > Thanks for the feedback. > > Thanks > Ajit > > > > > Thanks