From: Leon Romanovsky <leon@kernel.org>
To: Cheng Xu <chengyou@linux.alibaba.com>
Cc: jgg@ziepe.ca, BMT@zurich.ibm.com, linux-rdma@vger.kernel.org
Subject: Re: [PATCH for-next] RDMA/siw: Fix duplicated reported IW_CM_EVENT_CONNECT_REPLY event
Date: Mon, 18 Jul 2022 14:21:38 +0300 [thread overview]
Message-ID: <YtVCQo+3RS9gSLqF@unreal> (raw)
In-Reply-To: <dae34b5fd5c2ea2bd9744812c1d2653a34a94c67.1657706960.git.chengyou@linux.alibaba.com>
On Thu, Jul 14, 2022 at 09:30:47AM +0800, Cheng Xu wrote:
> If siw_recv_mpa_rr returns -EAGAIN, it means that the MPA reply hasn't
> been received completely, and should not report IW_CM_EVENT_CONNECT_REPLY
> in this case. This may trigger a call trace in iw_cm. A simple way to
> trigger this:
> server: ib_send_lat
> client: ib_send_lat -R <server_ip>
>
> The call trace looks like this:
>
> kernel BUG at drivers/infiniband/core/iwcm.c:894!
> invalid opcode: 0000 [#1] PREEMPT SMP NOPTI
> <...>
> Workqueue: iw_cm_wq cm_work_handler [iw_cm]
> Call Trace:
> <TASK>
> cm_work_handler+0x1dd/0x370 [iw_cm]
> process_one_work+0x1e2/0x3b0
> worker_thread+0x49/0x2e0
> ? rescuer_thread+0x370/0x370
> kthread+0xe5/0x110
> ? kthread_complete_and_exit+0x20/0x20
> ret_from_fork+0x1f/0x30
> </TASK>
>
> Signed-off-by: Cheng Xu <chengyou@linux.alibaba.com>
> ---
> drivers/infiniband/sw/siw/siw_cm.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
Fixes: 6c52fdc244b5 ("rdma/siw: connection management")
Thanks, applied.
next prev parent reply other threads:[~2022-07-18 11:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-14 1:30 [PATCH for-next] RDMA/siw: Fix duplicated reported IW_CM_EVENT_CONNECT_REPLY event Cheng Xu
2022-07-18 11:21 ` Leon Romanovsky [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-07-14 12:59 Bernard Metzler
2022-07-14 13:20 ` Cheng Xu
2022-07-14 13:58 ` Bernard Metzler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YtVCQo+3RS9gSLqF@unreal \
--to=leon@kernel.org \
--cc=BMT@zurich.ibm.com \
--cc=chengyou@linux.alibaba.com \
--cc=jgg@ziepe.ca \
--cc=linux-rdma@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox