From: Leon Romanovsky <leon@kernel.org>
To: "lizhijian@fujitsu.com" <lizhijian@fujitsu.com>
Cc: Yanjun Zhu <yanjun.zhu@linux.dev>, Jason Gunthorpe <jgg@ziepe.ca>,
Haakon Bugge <haakon.bugge@oracle.com>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
Bob Pearson <rpearsonhpe@gmail.com>,
Cheng Xu <chengyou@linux.alibaba.com>
Subject: Re: [PATCH v5 0/4] RDMA/rxe: Fix no completion event issue
Date: Wed, 20 Jul 2022 09:33:30 +0300 [thread overview]
Message-ID: <YtehusQijNRTv0Jr@unreal> (raw)
In-Reply-To: <a19c2627-22d9-4362-66ee-bf66903d120a@fujitsu.com>
On Wed, Jul 20, 2022 at 06:21:29AM +0000, lizhijian@fujitsu.com wrote:
> Hi Leon
>
>
> On 20/07/2022 13:38, Leon Romanovsky wrote:
> > On Mon, Jul 04, 2022 at 06:00:54AM +0000, lizhijian@fujitsu.com wrote:
> >
> > Please fix your gitconfig to have same From/author fields as in Signed-off-by.
>
> I'm sorry about that, tay I know which patch has something wrong? I have not updated these fields recently.
> Do you mean "[PATCH v5 3/4] RDMA/rxe: Split qp state for requester and completer" which is from Bob. So
> I keep his author and SOB.
No, I'm talking about something else. Almost all your patches are sent
with wrong "From:" field.
Let's take your first patch as an example:
https://lore.kernel.org/linux-rdma/20220704060806.1622849-2-lizhijian@fujitsu.com/
From: "lizhijian@fujitsu.com" <lizhijian@fujitsu.com>
...
Signed-off-by: Li Zhijian <lizhijian@fujitsu.com>
and if i try to apply it, the checkpatch will throw the following error:
➜ kernel git:(rdma-next) ✗ git am --continue
Applying: RDMA/rxe: Update wqe_index for each wqe error completion
➜ kernel git:(rdma-next) git checkpatch
WARNING: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#9:
qp->req.wqe_index==queue.index in next round, req_next_wqe() will treat queue
WARNING: From:/Signed-off-by: email name mismatch: 'From: "lizhijian@fujitsu.com" <lizhijian@fujitsu.com>' != 'Signed-off-by: Li Zhijian <lizhijian@fujitsu.com>'
0001-RDMA-rxe-Update-wqe_index-for-each-wqe-error-complet.patch total: 0 errors, 2 warnings, 8 lines checked
>
> Thanks
> Zhijian
>
>
> >
> > Thanks
prev parent reply other threads:[~2022-07-20 6:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-04 6:00 [PATCH v5 0/4] RDMA/rxe: Fix no completion event issue lizhijian
2022-07-04 6:00 ` [PATCH v5 2/4] RDMA/rxe: Generate error completion for error requester QP state lizhijian
2022-07-04 6:00 ` [PATCH v5 1/4] RDMA/rxe: Update wqe_index for each wqe error completion lizhijian
2022-07-04 6:00 ` [PATCH v5 3/4] RDMA/rxe: Split qp state for requester and completer lizhijian
2022-07-04 6:00 ` [PATCH v5 4/4] RDMA/rxe: Fix typo in comment lizhijian
2022-07-14 17:10 ` Bob Pearson
2022-07-20 5:38 ` [PATCH v5 0/4] RDMA/rxe: Fix no completion event issue Leon Romanovsky
2022-07-20 6:21 ` lizhijian
2022-07-20 6:33 ` Leon Romanovsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YtehusQijNRTv0Jr@unreal \
--to=leon@kernel.org \
--cc=chengyou@linux.alibaba.com \
--cc=haakon.bugge@oracle.com \
--cc=jgg@ziepe.ca \
--cc=linux-rdma@vger.kernel.org \
--cc=lizhijian@fujitsu.com \
--cc=rpearsonhpe@gmail.com \
--cc=yanjun.zhu@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox