From: Jason Gunthorpe <jgg@nvidia.com>
To: Bob Pearson <rpearsonhpe@gmail.com>
Cc: "lizhijian@fujitsu.com" <lizhijian@fujitsu.com>,
"zyjzyj2000@gmail.com" <zyjzyj2000@gmail.com>,
"jhack@hpe.com" <jhack@hpe.com>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>
Subject: Re: [PATCH v4 for-next] RDMA/rxe: Fix error paths in MR alloc routines
Date: Fri, 5 Aug 2022 15:21:03 -0300 [thread overview]
Message-ID: <Yu1fj7KrQ84r7A1y@nvidia.com> (raw)
In-Reply-To: <cf1c298c-11bb-e072-8f5e-ff4aad4963c2@gmail.com>
On Fri, Aug 05, 2022 at 12:48:32PM -0500, Bob Pearson wrote:
> On 8/5/22 02:08, lizhijian@fujitsu.com wrote:
> > Bob
> >
> > It does fix the panic.
> >
> > TBH i'm not a big fan with you patches style, you didn't make the smallest patch.
> > You made a lots of extra cleanups and coding style fixes which is good to me in logical
> > but it make patches massive. that would take people more attention to have a review.
> >
> > I'd like a smallest fix + extra cleanup if needed, the decision is up to the maintainers :)
> >
> >
> >
> Li,
>
> OK. I'll split it up. I'm ambivalent on goto's. Some days I like them and some I don't. No logical reason.
> In this particular case I was concerned with making absolutely sure that the cleanups balanced out.
> So I touched all that code in passing. Now that it works. I can reduce the change.
kernel style is goto unwind on error, you should use it freely and
never duplicate error unwind in branches..
Jason
prev parent reply other threads:[~2022-08-05 18:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-04 4:37 [PATCH v4 for-next] RDMA/rxe: Fix error paths in MR alloc routines Bob Pearson
2022-08-04 4:42 ` Bob Pearson
2022-08-05 7:08 ` lizhijian
2022-08-05 17:48 ` Bob Pearson
2022-08-05 18:21 ` Jason Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yu1fj7KrQ84r7A1y@nvidia.com \
--to=jgg@nvidia.com \
--cc=jhack@hpe.com \
--cc=linux-rdma@vger.kernel.org \
--cc=lizhijian@fujitsu.com \
--cc=rpearsonhpe@gmail.com \
--cc=zyjzyj2000@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox