From: Jason Gunthorpe <jgg@nvidia.com>
To: Bob Pearson <rpearsonhpe@gmail.com>
Cc: zyjzyj2000@gmail.com, haris.iqbal@ionos.com, linux-rdma@vger.kernel.org
Subject: Re: [PATCH for-next v2] RDMA/rxe: Cleanup rxe_init_packet()
Date: Thu, 28 Jul 2022 13:08:12 -0300 [thread overview]
Message-ID: <YuK0a67aTpMWJgeE@nvidia.com> (raw)
In-Reply-To: <20220727163651.6967-1-rpearsonhpe@gmail.com>
On Wed, Jul 27, 2022 at 11:36:52AM -0500, Bob Pearson wrote:
> unsigned int hdr_len;
> struct sk_buff *skb = NULL;
> - struct net_device *ndev;
> - const struct ib_gid_attr *attr;
> + struct net_device *ndev = rxe->ndev;
> const int port_num = 1;
> -
> - attr = rdma_get_gid_attr(&rxe->ib_dev, port_num, av->grh.sgid_index);
> - if (IS_ERR(attr))
> - return NULL;
An ib_device can have many netdevs associated with the gid indexes, eg
from VLANs or LAG. The core code creates these things
I think it is nonsense for rxe to work like this, and perhaps it
doesn't work at all, but until rxe blocks creation of these other gid
indexes I'm not sure it makes sense to delete this code..
Jason
next prev parent reply other threads:[~2022-07-28 17:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-27 16:36 [PATCH for-next v2] RDMA/rxe: Cleanup rxe_init_packet() Bob Pearson
2022-07-28 16:08 ` Jason Gunthorpe [this message]
2022-07-28 18:04 ` Bob Pearson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YuK0a67aTpMWJgeE@nvidia.com \
--to=jgg@nvidia.com \
--cc=haris.iqbal@ionos.com \
--cc=linux-rdma@vger.kernel.org \
--cc=rpearsonhpe@gmail.com \
--cc=zyjzyj2000@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox