Linux RDMA and InfiniBand development
 help / color / mirror / Atom feed
From: Leon Romanovsky <leon@kernel.org>
To: Jason Gunthorpe <jgg@nvidia.com>
Cc: Aharon Landau <aharonl@nvidia.com>, linux-rdma@vger.kernel.org
Subject: Re: [PATCH rdma-next] RDMA/mlx5: Don't compare mkey tags in DEVX indirect mkey
Date: Tue, 16 Aug 2022 15:19:50 +0300	[thread overview]
Message-ID: <YvuLZp1mWX/5dOM5@unreal> (raw)
In-Reply-To: <3d669aacea85a3a15c3b3b953b3eaba3f80ef9be.1659255945.git.leonro@nvidia.com>

On Sun, Jul 31, 2022 at 11:26:36AM +0300, Leon Romanovsky wrote:
> From: Aharon Landau <aharonl@nvidia.com>
> 
> According to the ib spec:
> If the CI supports the Base Memory Management Extensions defined in this
> specification, the L_Key format must consist of:
> 24 bit index in the most significant bits of the R_Key, and
> 8 bit key in the least significant bits of the R_Key
> Through a successful Allocate L_Key verb invocation, the CI must let the
> consumer own the key portion of the returned R_Key
> 
> Therefore, when creating a mkey using DEVX, the consumer is allowed to
> change the key part. The kernel should compare only the index part of a
> R_Key to determine equality with another R_Key.
> 
> Adding capability in order not to break backward compatibility.
> 
> Fixes: 534fd7aac56a ("IB/mlx5: Manage indirection mkey upon DEVX flow for ODP")
> Signed-off-by: Aharon Landau <aharonl@nvidia.com>
> Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
> ---
>  drivers/infiniband/hw/mlx5/main.c | 3 +++
>  drivers/infiniband/hw/mlx5/odp.c  | 3 ++-
>  include/uapi/rdma/mlx5-abi.h      | 1 +
>  3 files changed, 6 insertions(+), 1 deletion(-)
> 

Thanks, applied

      reply	other threads:[~2022-08-16 12:20 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-31  8:26 [PATCH rdma-next] RDMA/mlx5: Don't compare mkey tags in DEVX indirect mkey Leon Romanovsky
2022-08-16 12:19 ` Leon Romanovsky [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YvuLZp1mWX/5dOM5@unreal \
    --to=leon@kernel.org \
    --cc=aharonl@nvidia.com \
    --cc=jgg@nvidia.com \
    --cc=linux-rdma@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox