From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1ECB5C25B0E for ; Tue, 16 Aug 2022 12:57:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233260AbiHPM5n (ORCPT ); Tue, 16 Aug 2022 08:57:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53896 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229491AbiHPM5P (ORCPT ); Tue, 16 Aug 2022 08:57:15 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 597D8564C4 for ; Tue, 16 Aug 2022 05:57:14 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 136A2B818E2 for ; Tue, 16 Aug 2022 12:57:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4DF39C433C1; Tue, 16 Aug 2022 12:57:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1660654631; bh=avOMma8tkkuIdM6mytCoTTpKXfOZ4V14lThfncRl8jc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=SSU00J/FEiudw0gWr5YDkg1HpXmKx/nKOAVDGFIY0E0dDka7miXwdGy++UvkGb/Qa EFrPRBXjSINC8C0meyDqZbfIHJcUysCAxoSGvD6DY+y1+3MVgztaZQFCpnDZcSANc5 j2I07S7gRpIy75jr7Z/ODlE+9EboHtOcHWmKz7NMc3iex0HdS0tscSIJR1J56vcjsc +yHiG+Q/kDoMULmn87kU1IV6SVqfJFhejuvA9kuNCjlBLros3HXruOeZlaH3ML3wWv ReMvMgZl6W+SaADFIDzs6mHlgqkUc5gYVqLykpE59gr78h4RJY3xVXACfr1+tcYUYS gTDTpFIBzkKhA== Date: Tue, 16 Aug 2022 15:57:07 +0300 From: Leon Romanovsky To: Sergey Gorenko Cc: Sagi Grimberg , linux-rdma@vger.kernel.org, Max Gurtovoy Subject: Re: [PATCH] IB/iser: Fix login with authentication Message-ID: References: <20220805060135.18493-1-sergeygo@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220805060135.18493-1-sergeygo@nvidia.com> Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On Fri, Aug 05, 2022 at 09:01:35AM +0300, Sergey Gorenko wrote: > The iSER Initiator uses two types of receive buffers: > > - one big login buffer posted by iser_post_recvl(); > - several small message buffers posted by iser_post_recvm(). > > The login buffer is used at the login phase and full feature phase in > the discovery session. It may take a few requests and responses to > complete the login phase. The message buffers are only used in the > normal operational session at the full feature phase. > > After the commit referred in the fixes line, the login operation fails > if the authentication is enabled. That happens because the Initiator > posts a small receive buffer after the first response from Target. So, > the next send operation fails because Target's second response does not > fit into the small receive buffer. > > This commit adds additional checks to prevent posting small receive > buffers until the full feature phase. > > Fixes: 39b169ea0d36 ("IB/iser: Fix RNR errors") > Signed-off-by: Sergey Gorenko > Reviewed-by: Max Gurtovoy > --- > drivers/infiniband/ulp/iser/iser_initiator.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > Thanks, applied to -rc.