Re: [PATCH 2/2] RDMA: dma-mapping: Return an unsigned int from ib_dma_map_sg{,_attrs}

Jinpu Wang
2022-08-29T09:41:22Z

On Sun, Aug 28, 2022 at 1:09 PM Leon Romanovsky <leon@kernel.org> wrote:
>
> On Fri, Aug 26, 2022 at 11:56:15AM +0200, Jack Wang wrote:
> > Following 2a047e0662ae ("dma-mapping: return an unsigned int from dma_map_sg{,_attrs}")
> > change the return value of ib_dma_map_sg{,attrs} to unsigned int.
> >
> > Cc: Jason Gunthorpe <jgg@ziepe.ca>
> > Cc: Leon Romanovsky <leon@kernel.org>
> > Cc: Christoph Hellwig <hch@lst.de>
> > Cc: linux-rdma@vger.kernel.org
> > Cc: linux-kernel@vger.kernel.org
> >
> > Signed-off-by: Jack Wang <jinpu.wang@ionos.com>
> > ---
> > drivers/infiniband/core/device.c | 2 +-
> > include/rdma/ib_verbs.h | 6 +++---
> > 2 files changed, 4 insertions(+), 4 deletions(-)
>
> You forgot to change ib_dma_map_sgtable_attrs() and various
> ib_dma_map_sg*() callers.
No, they are different.
ib_dma_map_sgtable_attrs and dma_map_sgtable return negative on errors.
>
> Thanks
Thanks!