From: Jason Gunthorpe <jgg@ziepe.ca>
To: Tom Talpey <tom@talpey.com>
Cc: Cheng Xu <chengyou@linux.alibaba.com>,
leon@kernel.org, linux-rdma@vger.kernel.org,
KaiShen@linux.alibaba.com
Subject: Re: [PATCH for-next 0/2] RDMA/erdma: Introduce custom implementation of drain_sq and drain_rq
Date: Fri, 26 Aug 2022 10:57:43 -0300 [thread overview]
Message-ID: <YwjRV3kubU9wnwax@ziepe.ca> (raw)
In-Reply-To: <8ad2446d-157b-3894-c0a3-f8a57a6e1c34@talpey.com>
On Fri, Aug 26, 2022 at 09:11:25AM -0400, Tom Talpey wrote:
> With your change, ERDMA will pre-emptively fail such a newly posted
> request, and generate no new completion. The consumer is left in limbo
> on the status of its prior requests. Providers must not override this.
Yeah, I tend to agree with Tom.
And I also want to point out that Linux RDMA verbs does not follow the
SW specifications of either IBTA or the iWarp group. We have our own
expectation for how these APIs work that our own ULPs rely on.
So pedantically debating what a software spec we don't follow says is
not relavent. The utility is to understand the intention and use cases
and ensure we cover the same. Usually this means we follow the spec :)
Jason
next prev parent reply other threads:[~2022-08-26 13:57 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-24 9:42 [PATCH for-next 0/2] RDMA/erdma: Introduce custom implementation of drain_sq and drain_rq Cheng Xu
2022-08-24 9:42 ` [PATCH for-next 1/2] RDMA/erdma: Introduce internal post_send/post_recv for qp drain Cheng Xu
2022-08-24 12:10 ` Leon Romanovsky
2022-08-24 9:42 ` [PATCH for-next 2/2] RDMA/erdma: Add drain_sq and drain_rq support Cheng Xu
2022-08-24 12:10 ` Leon Romanovsky
2022-08-25 1:59 ` Cheng Xu
2022-08-24 14:08 ` [PATCH for-next 0/2] RDMA/erdma: Introduce custom implementation of drain_sq and drain_rq Tom Talpey
2022-08-24 14:56 ` Bernard Metzler
2022-08-25 1:54 ` Cheng Xu
2022-08-25 16:37 ` Tom Talpey
2022-08-26 3:21 ` Cheng Xu
2022-08-26 13:11 ` Tom Talpey
2022-08-26 13:57 ` Jason Gunthorpe [this message]
2022-08-29 4:01 ` Cheng Xu
2022-08-30 18:45 ` Tom Talpey
2022-08-31 2:08 ` Cheng Xu
2022-08-31 2:52 ` Cheng Xu
2022-08-29 3:37 ` Cheng Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YwjRV3kubU9wnwax@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=KaiShen@linux.alibaba.com \
--cc=chengyou@linux.alibaba.com \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=tom@talpey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox