From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F326ECAAD4 for ; Mon, 29 Aug 2022 07:02:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229536AbiH2HCr (ORCPT ); Mon, 29 Aug 2022 03:02:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46802 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229521AbiH2HCr (ORCPT ); Mon, 29 Aug 2022 03:02:47 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7BEC5474C7 for ; Mon, 29 Aug 2022 00:02:46 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 31826B80CCA for ; Mon, 29 Aug 2022 07:02:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 60CC2C433D6; Mon, 29 Aug 2022 07:02:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1661756563; bh=RSlUn73BULfL/+paoWL1o9HbOHo1o3wotRpUZQPKkI0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=nMgpCRHkeSJbRosw1fxAINCBeRlAoR46f0clrT96Q64u6FFwxzyxP+ocT+PH/8B/P ZKk16StCM1ADNB2Qg4MdTieC7eGkhg8PxYVhpe3tkNiP6031iC7mwkobFrEPfnYwQm bSHvx7qhAC3Rtx9sQF07HEsTcZkHFQKW/+w6dRpsnE/kZUqo3RL2maTi56ENZ0EewH aY7sgrA6af0UNb5dnWOAT7kF2TVctov44Bth8QWHlwbeXH0JvNYpCUuBE8u8d5hFOu IbMFE3QnAUln238yThnshfOpIS7LelVVy1U+tGwSHBn8nKOrrMsGaJfN63gikA8Tp0 pAyVS9AEVGZsQ== Date: Mon, 29 Aug 2022 10:02:39 +0300 From: Leon Romanovsky To: Zhu Yanjun Cc: Daisuke Matsuda , Jason Gunthorpe , RDMA mailing list Subject: Re: [PATCH] RDMA/rxe: Delete error messages triggered by incoming Read requests Message-ID: References: <20220829054413.1630495-1-matsuda-daisuke@fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On Mon, Aug 29, 2022 at 02:31:00PM +0800, Zhu Yanjun wrote: > On Mon, Aug 29, 2022 at 1:45 PM Daisuke Matsuda > wrote: > > > > An incoming Read request causes multiple Read responses. If a user MR to > > copy data from is unavailable or responder cannot send a reply, then the > > error messages can be printed for each response attempt, resulting in > > message overflow. > > > > Signed-off-by: Daisuke Matsuda > > --- > > drivers/infiniband/sw/rxe/rxe_resp.c | 6 +----- > > 1 file changed, 1 insertion(+), 5 deletions(-) > > > > diff --git a/drivers/infiniband/sw/rxe/rxe_resp.c b/drivers/infiniband/sw/rxe/rxe_resp.c > > index b36ec5c4d5e0..4b3e8aec2fb8 100644 > > --- a/drivers/infiniband/sw/rxe/rxe_resp.c > > +++ b/drivers/infiniband/sw/rxe/rxe_resp.c > > @@ -811,8 +811,6 @@ static enum resp_states read_reply(struct rxe_qp *qp, > > > > err = rxe_mr_copy(mr, res->read.va, payload_addr(&ack_pkt), > > payload, RXE_FROM_MR_OBJ); > > - if (err) > > - pr_err("Failed copying memory\n"); > > pr_err_once is better? Like Jason said, there shouldn't any prints in network triggered flows. Thanks