Re: [PATCH] RDMA/siw: Add missing Kconfig selections

[Leon Romanovsky <leon@kernel.org>]

On Wed, Aug 31, 2022 at 12:30:48PM -0400, Tom Talpey wrote:
> The SoftiWARP Kconfig is missing "select" for CRYPTO and CRYPTO_CRC32C.
> 
> In addition, it improperly "depends on" LIBCRC32C, this should be a
> "select", similar to net/sctp and others. As a dependency, SIW fails
> to appear in generic configurations.
> 
> Signed-off-by: Tom Talpey <tom@talpey.com>
> ---
>  drivers/infiniband/sw/siw/Kconfig | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/infiniband/sw/siw/Kconfig
> b/drivers/infiniband/sw/siw/Kconfig

I don't know how you created the patch and sent it later, but it broken.
1. diff --git line above was broken to two lines. It causes to the
following error:
➜  kernel git:(wip/leon-for-next) ✗ git am -s ./20220831_tom_rdma_siw_add_missing_kconfig_selections.mbx
Applying: RDMA/siw: Add missing Kconfig selections
error: git diff header lacks filename information when removing 1 leading pathname component (line 6)
Patch failed at 0001 RDMA/siw: Add missing Kconfig selections
....
2. You changed tabs to white spaces in the patch itself.
➜  kernel git:(wip/leon-for-next) ✗ git am --reject -s ./20220831_tom_rdma_siw_add_missing_kconfig_selections.mbx
Applying: RDMA/siw: Add missing Kconfig selections
Checking patch drivers/infiniband/sw/siw/Kconfig...
error: while searching for:
 config RDMA_SIW
        tristate "Software RDMA over TCP/IP (iWARP) driver"
       depends on INET && INFINIBAND && LIBCRC32C
        depends on INFINIBAND_VIRT_DMA
        help
        This driver implements the iWARP RDMA transport over
        the Linux TCP/IP network stack. It enables a system with a

error: patch failed: drivers/infiniband/sw/siw/Kconfig:1
Applying patch drivers/infiniband/sw/siw/Kconfig with 1 reject...
Rejected hunk #1.
Patch failed at 0001 RDMA/siw: Add missing Kconfig selections

I fixed everything and applied to -next.

Thanks