From: Leon Romanovsky <leon@kernel.org>
To: Guoqing Jiang <guoqing.jiang@linux.dev>
Cc: haris.iqbal@ionos.com, jinpu.wang@ionos.com, jgg@ziepe.ca,
linux-rdma@vger.kernel.org
Subject: Re: [PATCH 0/3] misc changes for rtrs
Date: Mon, 5 Sep 2022 15:28:47 +0300 [thread overview]
Message-ID: <YxXrf1WKVwlDYgzm@unreal> (raw)
In-Reply-To: <20220902101922.26273-1-guoqing.jiang@linux.dev>
On Fri, Sep 02, 2022 at 06:19:19PM +0800, Guoqing Jiang wrote:
> Hi,
>
> Pls review the three patches.
>
> Thanks,
> Guoqing
>
> Guoqing Jiang (3):
> RDMA/rtrs: Update comments for MAX_SESS_QUEUE_DEPTH
> RDMA/rtrs-clt: Break the loop once one path is connected
> RDMA/rtrs-clt: Kill xchg_paths
>
> drivers/infiniband/ulp/rtrs/rtrs-clt.c | 18 +++++-------------
> drivers/infiniband/ulp/rtrs/rtrs-pri.h | 7 +++----
> 2 files changed, 8 insertions(+), 17 deletions(-)
The third patch still generates warnings.
➜ kernel git:(wip/leon-for-next) mkt ci
^[[A^[[A^[[Ad9b137e23d31 (HEAD -> build) RDMA/rtrs-clt: Kill xchg_paths
WARNING: line length of 81 exceeds 80 columns
#43: FILE: drivers/infiniband/ulp/rtrs/rtrs-clt.c:2297:
+ if (try_cmpxchg((typeof(ppcpu_path))ppcpu_path, &clt_path, next))
drivers/infiniband/ulp/rtrs/rtrs-clt.c:2297:21: warning: incorrect type in initializer (different address spaces)
drivers/infiniband/ulp/rtrs/rtrs-clt.c:2297:21: expected struct rtrs_clt_path [noderef] __rcu *__new
drivers/infiniband/ulp/rtrs/rtrs-clt.c:2297:21: got struct rtrs_clt_path *[assigned] next
>
> --
> 2.31.1
>
next prev parent reply other threads:[~2022-09-05 12:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-02 10:19 [PATCH 0/3] misc changes for rtrs Guoqing Jiang
2022-09-02 10:19 ` [PATCH 1/3] RDMA/rtrs: Update comments for MAX_SESS_QUEUE_DEPTH Guoqing Jiang
2022-09-02 10:19 ` [PATCH 2/3] RDMA/rtrs-clt: Break the loop once one path is connected Guoqing Jiang
2022-09-02 10:19 ` [PATCH 3/3] RDMA/rtrs-clt: Kill xchg_paths Guoqing Jiang
2022-09-02 19:15 ` kernel test robot
2022-09-03 3:54 ` Guoqing Jiang
2022-09-03 4:02 ` [Updated PATCH " Guoqing Jiang
2022-09-05 12:28 ` Leon Romanovsky [this message]
2022-09-06 7:04 ` [PATCH 0/3] misc changes for rtrs Guoqing Jiang
2022-09-06 11:13 ` Leon Romanovsky
2022-09-08 8:53 ` Haris Iqbal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YxXrf1WKVwlDYgzm@unreal \
--to=leon@kernel.org \
--cc=guoqing.jiang@linux.dev \
--cc=haris.iqbal@ionos.com \
--cc=jgg@ziepe.ca \
--cc=jinpu.wang@ionos.com \
--cc=linux-rdma@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox