From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EEB77C38145 for ; Wed, 7 Sep 2022 12:51:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229710AbiIGMva (ORCPT ); Wed, 7 Sep 2022 08:51:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56258 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229915AbiIGMv0 (ORCPT ); Wed, 7 Sep 2022 08:51:26 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BFF997CB65 for ; Wed, 7 Sep 2022 05:51:24 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 757B3B81CC0 for ; Wed, 7 Sep 2022 12:51:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9835CC4347C; Wed, 7 Sep 2022 12:51:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1662555081; bh=kX1fEdgbpgeA+Uc8I3t0B7Xx7X2EuMPL087s9UV+c7I=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=HmX93yQ3sFuVa9lihJ3zpYeGa2Muqh+3fFQSPlD2KcVAEhHe8AFjBA1VEAPJEk2ia xoC7f6RppiO/J/MbLdYKRwtqxvM67F8ftQao6oTLgGvQrCjrNZ/jX9GCBCy4aVOal3 qJL7kOvw2UldC8IzXCdX4Ctq5F6MS5r6WtLLZ93tShOzif7qvL/DQX0bqf9Iuv4amC hcOOrlXAujne6TQ31ua31CGohwIpLVjKxx3kL3Eunv/egjGwp85ynV0vBgvhBmZOeI 2jY+U6kr3c9ZANudMeJ4fKqAmNNKt3P6iL17vZcpzDPWTj/L9nZLVNN4hEMNYgC8f/ ioWq7NA3tU/NA== Date: Wed, 7 Sep 2022 15:51:16 +0300 From: Leon Romanovsky To: Sagi Grimberg Cc: Patrisious Haddad , Christoph Hellwig , Israel Rukshin , Linux-nvme , linux-rdma@vger.kernel.org, Michael Guralnik , Maor Gottlieb , Max Gurtovoy Subject: Re: [PATCH rdma-next 4/4] nvme-rdma: add more error details when a QP moves to an error state Message-ID: References: <20220907113800.22182-1-phaddad@nvidia.com> <20220907113800.22182-5-phaddad@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On Wed, Sep 07, 2022 at 03:34:21PM +0300, Sagi Grimberg wrote: > > > From: Israel Rukshin > > > > Add debug prints for fatal QP events that are helpful for finding the > > root cause of the errors. The ib_get_qp_err_syndrome is called at > > a work queue since the QP event callback is running on an > > interrupt context that can't sleep. > > > > Signed-off-by: Israel Rukshin > > Reviewed-by: Max Gurtovoy > > Reviewed-by: Leon Romanovsky > > What makes nvme-rdma special here? Why do you get this in > nvme-rdma and not srp/iser/nfs-rdma/rds/smc/ipoib etc? > > This entire code needs to move to the rdma core instead > of being leaked to ulps. We can move, but you will lose connection between queue number, caller and error itself. As I answered to Christoph, we will need to execute query QP command in a workqueue outside of event handler. So you will get a print about queue in error state and later you will see parsed error print somewhere in the dmesg. Thanks