From: Jason Gunthorpe <jgg@nvidia.com>
To: Tom Talpey <tom@talpey.com>
Cc: Leon Romanovsky <leonro@nvidia.com>,
Bernard Metzler <bmt@zurich.ibm.com>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>
Subject: Re: [PATCH] Add missing ib_uverbs dependency from SoftiWARP
Date: Wed, 7 Sep 2022 10:51:24 -0300 [thread overview]
Message-ID: <Yxih3M3rym7Abt0P@nvidia.com> (raw)
In-Reply-To: <4e7574d7-960f-9f92-e92f-630287f1903f@talpey.com>
On Wed, Sep 07, 2022 at 09:45:07AM -0400, Tom Talpey wrote:
> When loading the siw module, ib_uverbs is needed so that consumers may
> access it. However, siw references only inline functions in ib_uverbs.h,
> so the kernel linker can not detect this, and the module is not loaded
> automatically. Add a module dependency to ensure ib_uverbs is present.
No, that is not how things work.
Modern rdma-core will auto-load uverbs when something uses it, we
shouldn't have things like this.
Jason
next prev parent reply other threads:[~2022-09-07 13:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-07 13:45 [PATCH] Add missing ib_uverbs dependency from SoftiWARP Tom Talpey
2022-09-07 13:51 ` Jason Gunthorpe [this message]
2022-09-07 13:57 ` Bernard Metzler
2022-09-07 13:57 ` Tom Talpey
2022-09-07 14:06 ` Jason Gunthorpe
2022-09-07 15:24 ` Tom Talpey
2022-09-07 16:48 ` Jason Gunthorpe
2022-09-07 17:54 ` Tom Talpey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yxih3M3rym7Abt0P@nvidia.com \
--to=jgg@nvidia.com \
--cc=bmt@zurich.ibm.com \
--cc=leonro@nvidia.com \
--cc=linux-rdma@vger.kernel.org \
--cc=tom@talpey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox