From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE84DECAAD8 for ; Wed, 21 Sep 2022 16:32:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231829AbiIUQcK (ORCPT ); Wed, 21 Sep 2022 12:32:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57656 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230447AbiIUQby (ORCPT ); Wed, 21 Sep 2022 12:31:54 -0400 Received: from mail-qv1-xf31.google.com (mail-qv1-xf31.google.com [IPv6:2607:f8b0:4864:20::f31]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7DEE4A0254 for ; Wed, 21 Sep 2022 09:12:49 -0700 (PDT) Received: by mail-qv1-xf31.google.com with SMTP id w4so4839883qvp.2 for ; Wed, 21 Sep 2022 09:12:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date; bh=aLY4X7jLe6jyDRz2GTUZzGVaQ/S9bUP0pVCXbM8UVnQ=; b=TPua4QONi/9P40ftlbD8dp1zg3rSaSqwpFR9IQzhC+qUz1Fp3XC86DD38Rs/IlQteT mhC8Q5Ip34T/drUuWDOAfP1w5Oi+o3MIAt6huHmVSGRHAfvDxMkYPwWMLUYsAoklf+TI sxQOINPIDXAzIClL8JUhpvoygyw7Nis8ZOPbHv3tOG/kJziCrdKCGR+zD+16Q7jWBvTx b3sq4muQd7s2scTDNZUMlsJKdu+5ZncIwc1pHEMCFOdb7DZbcEEju2zkpk9hHJf5f2Fx SDo/2l8RLlcEYe8UX5BENtEoK6jqG3kQdYjEbcER6ehHkpYkrf6sEaflGItWS+Z81gTl /TOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=aLY4X7jLe6jyDRz2GTUZzGVaQ/S9bUP0pVCXbM8UVnQ=; b=OhKXB2TjE155+NEl0pzUgy45sxRdi/OPR3rhVvJEaSu09GA4Q9vI9XBemGwh1D8Fvp 63D3VNVATIBRoWBCGlClWjkVMLv4RHMIwI97f4UawSvGeJjprSpr1JbwJetS7UWme26X wS7GyL8nIunySRiDfxbnfpotZWDqju4larK7UrR+wOKuJbgoBMfFXZDzNj34D6P3EZDE v7l7+uqTy0M9seOxRco4hqE00sQMiJ7mmcvop+ak3Qf7hjgNHgATCvn82wR+4wrHHDAk u1/xkFA2d8lxyL4CK0qqRUN+wSFSMVy66mgHQJhlfeUYPjpYTPZjog8449sJVO9jnuWc JpZw== X-Gm-Message-State: ACrzQf2sR6vwqyh/UeaF4VGkyfZnu8xGk+DBms7Zh0nid1SympBWK/Gv S45n+98fNdn7SvX8vpKGrd6tdA== X-Google-Smtp-Source: AMsMyM456CtmBnPUaHOLnSGIaudSOSiBnahdUvNlkNTz0WVQ9WE8C2u4WZr6oZuKp7Qi+VeOkmaN3g== X-Received: by 2002:ad4:5f47:0:b0:4ac:b8de:1484 with SMTP id p7-20020ad45f47000000b004acb8de1484mr23810326qvg.77.1663776757853; Wed, 21 Sep 2022 09:12:37 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-142-162-113-129.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.162.113.129]) by smtp.gmail.com with ESMTPSA id bs39-20020a05620a472700b006bad7a2964fsm2065622qkb.78.2022.09.21.09.12.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Sep 2022 09:12:37 -0700 (PDT) Received: from jgg by wakko with local (Exim 4.95) (envelope-from ) id 1ob2Ky-000qF4-Lc; Wed, 21 Sep 2022 13:12:36 -0300 Date: Wed, 21 Sep 2022 13:12:36 -0300 From: Jason Gunthorpe To: Dexuan Cui Cc: Long Li , KY Srinivasan , Haiyang Zhang , Stephen Hemminger , Wei Liu , "David S. Miller" , Jakub Kicinski , Paolo Abeni , Leon Romanovsky , "edumazet@google.com" , "shiraz.saleem@intel.com" , Ajay Sharma , "linux-hyperv@vger.kernel.org" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-rdma@vger.kernel.org" Subject: Re: [Patch v5 12/12] RDMA/mana_ib: Add a driver for Microsoft Azure Network Adapter Message-ID: References: <1661906071-29508-1-git-send-email-longli@linuxonhyperv.com> <1661906071-29508-13-git-send-email-longli@linuxonhyperv.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On Tue, Sep 20, 2022 at 05:54:19PM +0000, Dexuan Cui wrote: > > +int mana_ib_gd_create_dma_region(struct mana_ib_dev *dev, struct > > ib_umem *umem, > > + mana_handle_t *gdma_region, u64 page_sz) > > +{ > > ... > > + > > +if (!err) > > + return 0; > > Please add a Tab character to the above 2 lines. How are we still at the point where we have trivial style errors in this series at v6?? This is not OK, please handle reviews for this basic stuff internally. Jason