From: Leon Romanovsky <leon@kernel.org>
To: Jason Gunthorpe <jgg@nvidia.com>
Cc: Yanjun Zhu <yanjun.zhu@linux.dev>,
Leon Romanovsky <leo@kernel.org>,
linux-rdma@vger.kernel.org
Subject: Re: [PATCH] rdma: not display the rdma link in other net namespace
Date: Fri, 7 Oct 2022 09:21:30 +0300 [thread overview]
Message-ID: <Yz/FaiYZO5Y0R7QP@unreal> (raw)
In-Reply-To: <Yz8A6az2rIjEDEGk@nvidia.com>
On Thu, Oct 06, 2022 at 01:23:05PM -0300, Jason Gunthorpe wrote:
> On Thu, Oct 06, 2022 at 07:21:39PM +0300, Leon Romanovsky wrote:
>
> > > And in exclusive mode, a rdma link that can not be accessed in net namespace
> > > A still
> > >
> > > appears in net namespace A when running "rdma link show" in net namespace A.
> > >
> > > The above is different from others in net namespace.
> > >
> > > For example, in net namespace, if net device NIC0 is moved to net namespace
> > > B from net namespace A,
> > >
> > > this NIC0 will not appear in net namespace A when running "ip link" command
> > > in net namespace A.
> > >
> > > Is it a problem?
> >
> > rdmatool presents IB devices. It has no logic that decides if that
> > device is usable/operable or not.
>
> It should really not report an IB device that is not in the net
> namespace..
It is kernel (nldev.c) job to hide such IB devices and it seems like it
does. For devices with help of ib_enum_all_devs() and for links with
ib_device_get_by_index().
They both checks netns - rdma_dev_access_netns(device, net).
Thanks
next prev parent reply other threads:[~2022-10-07 6:21 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-26 2:40 [PATCH] rdma: not display the rdma link in other net namespace yanjun.zhu
2022-09-25 10:22 ` Yanjun Zhu
2022-09-27 10:34 ` Leon Romanovsky
2022-09-27 10:58 ` Yanjun Zhu
2022-09-28 6:04 ` Leon Romanovsky
2022-09-30 7:25 ` Yanjun Zhu
2022-10-06 12:53 ` Leon Romanovsky
2022-10-06 14:26 ` Yanjun Zhu
2022-10-06 16:21 ` Leon Romanovsky
2022-10-06 16:23 ` Jason Gunthorpe
2022-10-07 6:21 ` Leon Romanovsky [this message]
2022-10-07 6:56 ` Yanjun Zhu
2022-10-11 0:25 ` [RFC PATCH 1/1] RDMA/core: Fix a problem from rdma link in exclusive mode Zhu Yanjun
2022-10-11 10:12 ` Leon Romanovsky
2022-10-11 15:08 ` Yanjun Zhu
2022-10-13 8:30 ` yanjun.zhu
2022-10-09 10:20 ` [PATCH] rdma: not display the rdma link in other net namespace yanjun.zhu
2022-10-11 9:49 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yz/FaiYZO5Y0R7QP@unreal \
--to=leon@kernel.org \
--cc=jgg@nvidia.com \
--cc=leo@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=yanjun.zhu@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox