From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D157C433FE for ; Fri, 30 Sep 2022 18:05:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231426AbiI3SE6 (ORCPT ); Fri, 30 Sep 2022 14:04:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51558 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231781AbiI3SE5 (ORCPT ); Fri, 30 Sep 2022 14:04:57 -0400 Received: from mail-qv1-xf2d.google.com (mail-qv1-xf2d.google.com [IPv6:2607:f8b0:4864:20::f2d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4940128721 for ; Fri, 30 Sep 2022 11:04:54 -0700 (PDT) Received: by mail-qv1-xf2d.google.com with SMTP id i12so3294121qvs.2 for ; Fri, 30 Sep 2022 11:04:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date; bh=iqHbVanndELe5mjNZTy7OvpiCCuQgO+WYAxDnYsUJcY=; b=IHHCPlMXciC+5S1svHTsMJM4/glNZMU2sRpO6nK1xevj+9U8Y9eMJTID0GjtZoh9mS +O1xVGq1AvlaSQ8hInRe4VTrvKsQPiVxJVpmfN1MXlDEL9gp6evPfY5dctyYIZkWCAjb HTy1LKOJyDhgRAENtfKVDHgAlP7LCSHSi7ACzCAuv9BFF554W9HpgnYNnVDf1zVxBx8d oYhDJR+MjXbyvgffxljGnubXbxlk4sYxCAU6AcWvsehfJLKTm0xmtrnGIps7t1hIHnJz oLGGOcn059HCwFJcqgaQ9JUzJqPLjHy5DmXbWtZ3H2TeEUPPQBXhVAd08ZGn421F5SH/ 1/Vg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=iqHbVanndELe5mjNZTy7OvpiCCuQgO+WYAxDnYsUJcY=; b=ePZ072JBEf9V6+TWyhunP+qq31nEmfOMyXSQTXPxTY0+9O81Bniyxx2YnOR00Di9Zi UjF7FNU2dDA+eBSNK2ucp9T3c8f2VNfjJfQJasQTbhUoGA+1nV3k3tUcx28azCyG/htB YPfTBbvhyxnvEeqkQNV9/4arrB0pKEy8sTQcBXWmZ4e18070YRcKj8RL9gJr3S2t3E9Z N1wgdSRPF/Ao6yVXV2CyHOtdNWp+CILkCcPexn/J9mYz5H7iqtuQ8te81AxXcTVBSoc5 EOvHqV9/CKL+mQjJZJ0TC03hmrbyXwsm6DSLHT7OJCQizv5U4XvqvG+DRFIiWs4XfHKR 0+Og== X-Gm-Message-State: ACrzQf1vgrU2ajP+A5nLXklX5oFXTWGasX1Ayy4XQr5Pxi6XRjqz++bJ pINr60t+fi25Wlzrq9eZnd7yQA== X-Google-Smtp-Source: AMsMyM6t9laiIF4VuZRpnGYpLrHU5VcBrMIRDYhFEduEaYNrPENr04UL4LYlkCpOQ0lzxzeBxL8V4w== X-Received: by 2002:a05:6214:dc3:b0:4af:a98c:b0fa with SMTP id 3-20020a0562140dc300b004afa98cb0famr7775879qvt.99.1664561093196; Fri, 30 Sep 2022 11:04:53 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-47-55-122-23.dhcp-dynamic.fibreop.ns.bellaliant.net. [47.55.122.23]) by smtp.gmail.com with ESMTPSA id dm25-20020a05620a1d5900b006b8e63dfffbsm3449216qkb.58.2022.09.30.11.04.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Sep 2022 11:04:51 -0700 (PDT) Received: from jgg by wakko with local (Exim 4.95) (envelope-from ) id 1oeKNW-004NtZ-2U; Fri, 30 Sep 2022 15:04:50 -0300 Date: Fri, 30 Sep 2022 15:04:50 -0300 From: Jason Gunthorpe To: Li Zhijian Cc: Bob Pearson , Leon Romanovsky , linux-rdma@vger.kernel.org, Zhu Yanjun , yangx.jy@fujitsu.com, y-goto@fujitsu.com, mbloch@nvidia.com, liangwenpeng@huawei.com, tom@talpey.com, tomasz.gromadzki@intel.com, dan.j.williams@intel.com, linux-kernel@vger.kernel.org Subject: Re: [for-next PATCH v5 03/11] RDMA: Extend RDMA kernel verbs ABI to support flush Message-ID: References: <20220927055337.22630-1-lizhijian@fujitsu.com> <20220927055337.22630-4-lizhijian@fujitsu.com> <942fdca3-2cd4-88d2-033c-6bd3f7bb258a@fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <942fdca3-2cd4-88d2-033c-6bd3f7bb258a@fujitsu.com> Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On Thu, Sep 29, 2022 at 02:21:24PM +0800, Li Zhijian wrote: > we can see, IBV_ACCESS_REMOTE_ATOMIC and IBV_ACCESS_ON_DEMAND are > tagged "if supported" . but currently kernel just returns EINVAL > when user registers a MR with IB_ACCESS_ON_DEMAND to RXE. > > I wonder we should return -EOPNOTSUPP if the device doesn't support requested capabilities Yes, unsupported combinations of access flags should trigger EOPNOTSUPP Jason