From: Simona Vetter <simona.vetter@ffwll.ch>
To: "Christian König" <christian.koenig@amd.com>
Cc: Keith Busch <kbusch@kernel.org>, Wei Lin Guay <wguay@fb.com>,
alex.williamson@redhat.com, dri-devel@lists.freedesktop.org,
kvm@vger.kernel.org, linux-rdma@vger.kernel.org, jgg@nvidia.com,
vivek.kasireddy@intel.com, dagmoxnes@meta.com, nviljoen@meta.com,
Wei Lin Guay <wguay@meta.com>, Oded Gabbay <ogabbay@kernel.org>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
Leon Romanovsky <leon@kernel.org>,
Maor Gottlieb <maorg@nvidia.com>
Subject: Re: [PATCH 0/4] cover-letter: Allow MMIO regions to be exported through dmabuf
Date: Wed, 18 Dec 2024 11:44:39 +0100 [thread overview]
Message-ID: <Z2Knl1omccV-8Oa7@phenom.ffwll.local> (raw)
In-Reply-To: <0f207bf8-572a-4d32-bd24-602a0bf02d90@amd.com>
On Tue, Dec 17, 2024 at 10:53:32AM +0100, Christian König wrote:
> Am 16.12.24 um 17:54 schrieb Keith Busch:
> > On Mon, Dec 16, 2024 at 11:21:39AM +0100, Christian König wrote:
> > > Am 16.12.24 um 10:54 schrieb Wei Lin Guay:
> > > > From: Wei Lin Guay <wguay@meta.com>
> > > > However, as a general mechanism, it can support many other scenarios with
> > > > VFIO. I imagine this dmabuf approach to be usable by iommufd as well for
> > > > generic and safe P2P mappings.
> > > >
> > > > This series goes after the "Break up ioctl dispatch functions to one
> > > > function per ioctl" series.
> > > Yeah that sounds like it should work.
> > >
> > > But where is the rest of the series, I only see the cover letter?
> > Should be here:
> >
> > https://lore.kernel.org/linux-rdma/20241216095429.210792-2-wguay@fb.com/T/#u
>
> Please send that out once more with me on explicit CC.
>
> Apart from that I have to reject the adding of dma_buf_try_get(), that is
> clearly not something we should do.
Yeah if we do try_get it would need to be at least on a specific dma_buf
type (so checking for dma_buf->ops), since in general this does not work
(unless we add the general code in dma_buf.c somehow to make it work).
Aside from any other design concerns.
-Sima
--
Simona Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
next prev parent reply other threads:[~2024-12-18 10:44 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20241216095429.210792-1-wguay@fb.com>
2024-12-16 9:54 ` [PATCH 1/4] vfio: Add vfio_device_get() Wei Lin Guay
2024-12-16 9:54 ` [PATCH 2/4] dma-buf: Add dma_buf_try_get() Wei Lin Guay
2024-12-16 9:54 ` [PATCH 3/4] vfio/pci: Allow MMIO regions to be exported through dma-buf Wei Lin Guay
2024-12-16 9:54 ` [PATCH 4/4] vfio/pci: Allow export dmabuf without move_notify from importer Wei Lin Guay
2024-12-16 10:21 ` [PATCH 0/4] cover-letter: Allow MMIO regions to be exported through dmabuf Christian König
2024-12-16 16:54 ` Keith Busch
2024-12-17 9:53 ` Christian König
2024-12-17 11:06 ` Wei Lin Guay
[not found] ` <e8759159-b141-410b-be08-aad54eaed41f@amd.com>
2024-12-18 6:16 ` Kasireddy, Vivek
2024-12-18 10:01 ` Christian König
2024-12-19 7:02 ` Kasireddy, Vivek
2024-12-19 10:04 ` Christian König
2025-01-02 13:39 ` Jason Gunthorpe
2025-01-06 12:05 ` Simona Vetter
2025-01-06 16:27 ` Jason Gunthorpe
2025-01-08 16:48 ` Simona Vetter
2024-12-18 10:44 ` Simona Vetter [this message]
[not found] <20241216095920.237117-1-wguay@fb.com>
2024-12-16 17:34 ` Kasireddy, Vivek
2024-12-17 12:19 ` Wei Lin Guay
2024-12-18 7:02 ` Kasireddy, Vivek
[not found] ` <61DF4F0E-D947-436B-9160-A40079DB9085@meta.com>
2025-02-26 7:55 ` Kasireddy, Vivek
2025-02-26 13:38 ` Jason Gunthorpe
2025-02-26 17:59 ` Leon Romanovsky
2025-02-26 18:27 ` Wei Lin Guay
2025-03-04 7:15 ` Kasireddy, Vivek
2025-03-04 14:29 ` Christian König
2025-03-04 14:33 ` Jason Gunthorpe
2025-03-04 14:54 ` Leon Romanovsky
2025-02-26 18:24 ` Wei Lin Guay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z2Knl1omccV-8Oa7@phenom.ffwll.local \
--to=simona.vetter@ffwll.ch \
--cc=alex.williamson@redhat.com \
--cc=christian.koenig@amd.com \
--cc=dagmoxnes@meta.com \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=jgg@nvidia.com \
--cc=kbusch@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=maorg@nvidia.com \
--cc=nviljoen@meta.com \
--cc=ogabbay@kernel.org \
--cc=vivek.kasireddy@intel.com \
--cc=wguay@fb.com \
--cc=wguay@meta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).