From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CB9B019CC20 for ; Wed, 18 Dec 2024 10:44:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734518685; cv=none; b=cHbvNEUsCcnQnBzYoTDredYOcgaV76qd/zROLHHE+0fBx5hZlQxqbDu2THJ1JmkAz4Ca0eO3He4JIK3vKvKBBzQGsSAP6AugNDNnMHGTaKsVvEfpo9FNf1wo/T27Emf0CDbaDK2MObkczGGjt+6wR4/99ByEd42mvtBnijmQajo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734518685; c=relaxed/simple; bh=FgzAKdbWXLWHun90WMZSodB7l80udUFu2CLZktDUfm4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=gU6lSdiOschfoUxPK/1e/TVjEGwwn7hAb7wbkfO57Bc7rOIoqo4phAcOYQTr4c7HmixIb3UUh1VpvJix+cftkxAwsKm93/cUwQjgs5bKKjsiRE2pFrmPSfMgdDKl6JpHyx+tKEXV+JGrwUkFrhmAEobV5iLy4JksNcPl4dIK0Vs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch; spf=none smtp.mailfrom=ffwll.ch; dkim=pass (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b=B5oQE4Y/; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=ffwll.ch Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b="B5oQE4Y/" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-435f8f29f8aso45588635e9.2 for ; Wed, 18 Dec 2024 02:44:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; t=1734518682; x=1735123482; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=NQPNbO4Jh28X15Px0+LkPPkbR4yLtap4Vaw9U0pvMDM=; b=B5oQE4Y/BQCIREbjvnSQay2KhiUuxk3xnjDOCdI+tNcq6XQL7O+EW8ZiphrPSvCqvt D1VM8l+O4o9YFSLKtaMYnUMmJzY9kQLeN/Ggc5k90jA50a1bGrdLDvzUDSd26lGkZKXE w1OrzDtWIbaI0eEz7A3cTFhPQ98wdZHgsN9rk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734518682; x=1735123482; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=NQPNbO4Jh28X15Px0+LkPPkbR4yLtap4Vaw9U0pvMDM=; b=po8erUYyKBtcXCmU4gOu68bV+/L6Pyba4Ktun9f+881+3PXN5YUvxMOxQDtFXRFtv1 L68wm2wiX1Fg4akNo8zMjmTrtpSNsUksvY/hPJh0g8g+yC3DpVy8iZbKfLk57hV75ldn +4DoOALDfvgPILwqXmnUPkA3UIQXoKfpB28P8QzB5Rb45QBCFIIGjQiEsef2IaVMi4Vx lifEKa0ufRll+Zkfaf9h0SKr+okJsTrXC/O8E6keA2vJXrZ/tyqI+/AS9TAo4wb1zHmy DypFx9d8UOABAKtE7cmIeed/QurBE784m+1xnUVfAr+mro31fIFaJPPOeLHzQ0cEMSob MI3A== X-Forwarded-Encrypted: i=1; AJvYcCXqu15GzR2e+a09JCvmrfu2Z4kadTLy47Pay0TAb1peK7n64QD2D2WE6fCsjnPLYjcJG6eCKi9hK6Mm@vger.kernel.org X-Gm-Message-State: AOJu0YzAWb71LNu2kkpj4lw3RrA4OoamXNhjOYkQmlw9DSOdnXOql2Aa Z+UUVdPFbD0WAln1Uqzen9/8McefZEHP4QnmkgmPbv/F9IbBnDyRs5oRVVPRI/E= X-Gm-Gg: ASbGncvoNPoNdTUch7jvVar7I/qOPn1q+sbDIBJyNydNQ2mdD0bn7EHPwD9nl55oVtI Pb7TK13XbABuOQ3Oj9OVkqK5OW01rEp7u0BnrGmwCK0llzTFgq4uR2ancRl9sUh6FNGc+gEIjmh j5WhcNI2MteIh9vfKpNUKGujgRPCaTicU0yyrpfWxyr71U2NJyVx4gbPnHqbxKVqMvdH9UgCX2l mAeg+LVW57ykbvDyX5Xpac7+5E2ihdCa1R927fVnIEjE4kwO57YpqiSha0pwVpuiBAg X-Google-Smtp-Source: AGHT+IHcanVPmRLlzM2e6vfR41Z6Bf/R2ewaujydkQ7EOTyW5LtKeaoeAxoDwby+iMKdhpEeJt9o4w== X-Received: by 2002:a5d:6da6:0:b0:382:6f3:a20f with SMTP id ffacd0b85a97d-388e4d2de58mr2369209f8f.11.1734518682020; Wed, 18 Dec 2024 02:44:42 -0800 (PST) Received: from phenom.ffwll.local ([2a02:168:57f4:0:5485:d4b2:c087:b497]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-388c8046c05sm13901360f8f.73.2024.12.18.02.44.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Dec 2024 02:44:41 -0800 (PST) Date: Wed, 18 Dec 2024 11:44:39 +0100 From: Simona Vetter To: Christian =?iso-8859-1?Q?K=F6nig?= Cc: Keith Busch , Wei Lin Guay , alex.williamson@redhat.com, dri-devel@lists.freedesktop.org, kvm@vger.kernel.org, linux-rdma@vger.kernel.org, jgg@nvidia.com, vivek.kasireddy@intel.com, dagmoxnes@meta.com, nviljoen@meta.com, Wei Lin Guay , Oded Gabbay , Daniel Vetter , Leon Romanovsky , Maor Gottlieb Subject: Re: [PATCH 0/4] cover-letter: Allow MMIO regions to be exported through dmabuf Message-ID: References: <20241216095429.210792-1-wguay@fb.com> <89d9071b-0d3e-4fcd-963b-7aa234031a38@amd.com> <0f207bf8-572a-4d32-bd24-602a0bf02d90@amd.com> Precedence: bulk X-Mailing-List: linux-rdma@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <0f207bf8-572a-4d32-bd24-602a0bf02d90@amd.com> X-Operating-System: Linux phenom 6.12.3-amd64 On Tue, Dec 17, 2024 at 10:53:32AM +0100, Christian König wrote: > Am 16.12.24 um 17:54 schrieb Keith Busch: > > On Mon, Dec 16, 2024 at 11:21:39AM +0100, Christian König wrote: > > > Am 16.12.24 um 10:54 schrieb Wei Lin Guay: > > > > From: Wei Lin Guay > > > > However, as a general mechanism, it can support many other scenarios with > > > > VFIO. I imagine this dmabuf approach to be usable by iommufd as well for > > > > generic and safe P2P mappings. > > > > > > > > This series goes after the "Break up ioctl dispatch functions to one > > > > function per ioctl" series. > > > Yeah that sounds like it should work. > > > > > > But where is the rest of the series, I only see the cover letter? > > Should be here: > > > > https://lore.kernel.org/linux-rdma/20241216095429.210792-2-wguay@fb.com/T/#u > > Please send that out once more with me on explicit CC. > > Apart from that I have to reject the adding of dma_buf_try_get(), that is > clearly not something we should do. Yeah if we do try_get it would need to be at least on a specific dma_buf type (so checking for dma_buf->ops), since in general this does not work (unless we add the general code in dma_buf.c somehow to make it work). Aside from any other design concerns. -Sima -- Simona Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch