From: Jason Gunthorpe <jgg@ziepe.ca>
To: "Saleem, Shiraz" <shiraz.saleem@intel.com>
Cc: Tejun Heo <tj@kernel.org>,
"Ismail, Mustafa" <mustafa.ismail@intel.com>,
Leon Romanovsky <leon@kernel.org>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"kernel-team@fb.com" <kernel-team@fb.com>
Subject: Re: [PATCH] RDMA/irdma: Drop spurious WQ_UNBOUND from alloc_ordered_workqueue() call
Date: Fri, 21 Apr 2023 11:39:24 -0300 [thread overview]
Message-ID: <ZEKgHNlykqw7LmKm@ziepe.ca> (raw)
In-Reply-To: <MWHPR11MB0029F5F9C9AC249F2BC3E981E9609@MWHPR11MB0029.namprd11.prod.outlook.com>
On Fri, Apr 21, 2023 at 02:29:06PM +0000, Saleem, Shiraz wrote:
> > Subject: [PATCH] RDMA/irdma: Drop spurious WQ_UNBOUND from
> > alloc_ordered_workqueue() call
> >
> > Workqueue is in the process of cleaning up the distinction between unbound
> > workqueues w/ @nr_active==1 and ordered workqueues. Explicit
> > WQ_UNBOUND isn't needed for alloc_ordered_workqueue() and will trigger a
> > warning in the future. Let's remove it. This doesn't cause any functional
> > changes.
> >
> > Signed-off-by: Tejun Heo <tj@kernel.org>
> > ---
> > drivers/infiniband/hw/irdma/hw.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > --- a/drivers/infiniband/hw/irdma/hw.c
> > +++ b/drivers/infiniband/hw/irdma/hw.c
> > @@ -1901,8 +1901,8 @@ int irdma_ctrl_init_hw(struct irdma_pci_
> > break;
> > rf->init_state = CEQ0_CREATED;
> > /* Handles processing of CQP completions */
> > - rf->cqp_cmpl_wq = alloc_ordered_workqueue("cqp_cmpl_wq",
> > - WQ_HIGHPRI |
> > WQ_UNBOUND);
> > + rf->cqp_cmpl_wq =
> > + alloc_ordered_workqueue("cqp_cmpl_wq",
> > WQ_HIGHPRI);
> > if (!rf->cqp_cmpl_wq) {
> > status = -ENOMEM;
> > break;
>
> Acked-by: Shiraz Saleem <shiraz.saleem@intel.com>
Tejun, do you want this in your tree too?
Thanks
Jason
next prev parent reply other threads:[~2023-04-21 14:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-20 19:48 [PATCH] RDMA/irdma: Drop spurious WQ_UNBOUND from alloc_ordered_workqueue() call Tejun Heo
2023-04-21 14:29 ` Saleem, Shiraz
2023-04-21 14:39 ` Jason Gunthorpe [this message]
2023-04-21 14:41 ` Tejun Heo
2023-04-21 15:39 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZEKgHNlykqw7LmKm@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=kernel-team@fb.com \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=mustafa.ismail@intel.com \
--cc=shiraz.saleem@intel.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox