From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB649C77B75 for ; Fri, 5 May 2023 19:58:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229753AbjEET6y (ORCPT ); Fri, 5 May 2023 15:58:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43754 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229598AbjEET6y (ORCPT ); Fri, 5 May 2023 15:58:54 -0400 Received: from mail-qk1-x72f.google.com (mail-qk1-x72f.google.com [IPv6:2607:f8b0:4864:20::72f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 50B72197 for ; Fri, 5 May 2023 12:58:53 -0700 (PDT) Received: by mail-qk1-x72f.google.com with SMTP id af79cd13be357-74e3de79bf2so209361185a.2 for ; Fri, 05 May 2023 12:58:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1683316732; x=1685908732; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=D8/0Mz1i3TrsK5EuHofqZpbzmHEgycZi6NeOkBStzxc=; b=PibVkdMtrGXG4nJCsSpO+dyX40H7jVmFM5a/TLyr7glOsgpls3oaUCXmR2tz1P9ZQS aIq11OVfIkafWXqXLBrCAFAgg0Y6Uif246c/M7XoxGTk1/YmL+2TeAkyQxc6R/ur97Jd 560EkduqhNdBTHgYaJxzY6GKNBfDvZsCwGX9UabPP64GQQsIpsjxWgkSzQnstnioQBbB zrJ8fqnPhTpZ3eUY+phtcjta6ibdPYrH0Ywr6ylLKVGmvwmJ3bNo7C6hHj4haE+y1KXf h15FLI8dSGBt01m+IYnKWScqocAfpryZ41pbX20JqaysMzXYOuUkXh+0Mgl0yz70nuQ+ eEAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683316732; x=1685908732; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=D8/0Mz1i3TrsK5EuHofqZpbzmHEgycZi6NeOkBStzxc=; b=HBmLD6E0eCiFp4gS9EoIJoFd5M90izFK6dCNva1fkanzp9S2Wy95WurHo73fsfLQtg PHBOHpzYzD1gQhre+Mb7uJyE3KxEgJLF2pkE1UUC/VgngZYHfQvx34IPMPbW5bGyOf27 wOUEPDGPunDMkAsJj7XdgiaxAaGsCCWqz5Bl1OuEsyUWZZluYvUDyKgtZWOla7jGTb9a Ly21+twZDbhVpAljEo86w5LG86M1HXKQWKeDm6wf7KYObjxOo8Z3iRswlvjrJC0l0zAF Jkdh3NJPyBI+I1w+nwhfwNl2hZOEE0fURRjLW+kT31AnVkv7vq9dCwdG8jUiD/YN8k0d TlOw== X-Gm-Message-State: AC+VfDzqF5laiX76LyoglDa9QV6dLAFZgkRChbz08lGgZTDOmmYWDt1D P7YjWvwVOoS8vE+HO65aYlzWf2mCjT/NY0LA4YM= X-Google-Smtp-Source: ACHHUZ41Fdv176OLWVq9lKASou3V2H+AkTzBXpY6k9951af/PZTdY11T+LpjtJxw5VEsQnvjkhVp8Q== X-Received: by 2002:a05:622a:1a21:b0:3ef:36d0:c06e with SMTP id f33-20020a05622a1a2100b003ef36d0c06emr4858856qtb.33.1683316732523; Fri, 05 May 2023 12:58:52 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-142-68-25-194.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.68.25.194]) by smtp.gmail.com with ESMTPSA id n10-20020ac8674a000000b003df7d7bbc8csm853125qtp.75.2023.05.05.12.58.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 May 2023 12:58:51 -0700 (PDT) Received: from jgg by wakko with local (Exim 4.95) (envelope-from ) id 1pv1Zr-007zWe-A9; Fri, 05 May 2023 16:58:51 -0300 Date: Fri, 5 May 2023 16:58:51 -0300 From: Jason Gunthorpe To: Chuck Lever Cc: netdev@vger.kernel.org, linux-rdma@vger.kernel.org, BMT@zurich.ibm.com, tom@talpey.com Subject: Re: [PATCH RFC 3/3] RDMA/siw: Require non-zero 6-byte MACs for soft iWARP Message-ID: References: <168330051600.5953.11366152375575299483.stgit@oracle-102.nfsv4bat.org> <168330138101.5953.12575990094340826016.stgit@oracle-102.nfsv4bat.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <168330138101.5953.12575990094340826016.stgit@oracle-102.nfsv4bat.org> Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On Fri, May 05, 2023 at 11:43:11AM -0400, Chuck Lever wrote: > From: Chuck Lever > > In the past, LOOPBACK and NONE (tunnel) devices had all-zero MAC > addresses. siw_device_create() would fall back to copying the > device's name in those cases, because an all-zero MAC address breaks > the RDMA core IP-to-device lookup mechanism. Why not just make up a dummy address in SIW? It shouldn't need to leak out of it.. It is just some artifact of how the iWarp stuff has been designed Jason