From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2410BC7EE29 for ; Wed, 7 Jun 2023 14:10:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241028AbjFGOK5 (ORCPT ); Wed, 7 Jun 2023 10:10:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45438 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241033AbjFGOKy (ORCPT ); Wed, 7 Jun 2023 10:10:54 -0400 Received: from mail-pl1-x62b.google.com (mail-pl1-x62b.google.com [IPv6:2607:f8b0:4864:20::62b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 42E3A1BF0 for ; Wed, 7 Jun 2023 07:10:45 -0700 (PDT) Received: by mail-pl1-x62b.google.com with SMTP id d9443c01a7336-1b24eba184bso2682085ad.0 for ; Wed, 07 Jun 2023 07:10:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1686147044; x=1688739044; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=UA4hO4Sg2XutErgapC8W1zkxrTNWaXjtaVy5iI3CNaw=; b=gQrGNBCN6wg3gDSkzHUPCLOTgDfaTcWrZTB0MLWuAr16iUZyxRyQVaoV/HlulE6Ke7 vOiBehRR3EKFzUy/z/uOVwK9d0qLc6axSRyi5BSwc5VLE+AWORAIx1ji14Qy0uPW/eHD Xg1PX6HvaZijyrrUvxZQSBNwEkYNHyT+1tckU2H+bZ4YqVAv3xHt3veT16xsmld6FoOf 6vyJnqqpz8poqsyESJ4nGlCMuouGE9KnjAwESQ6ESKmHiu4JXxhkoUHVhez92Lpmd/oo DiR/b4tWZK8yODvRb4eH8rPZCopGKs/c0wchrTL2wbJLtqiTKMV6AqGeMBTx92rmms5W Bbgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686147044; x=1688739044; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=UA4hO4Sg2XutErgapC8W1zkxrTNWaXjtaVy5iI3CNaw=; b=Mtfajt7pnpfBs49yPglL4A/9+QY/hscum4cvVqyBGxF18OQOjEGYmMcTNViN5RjTjO JI/FQ4TOqtLtFcVnmkLB9rAzyDWB6UOh3Hphl7C7gC351ldYQXLnkb8TbhHUuBQGMisr d6EMDhQHz9rHWsqLCUEmw3F8awf9LlTsT0h8bdvfbDI4zz96heIlAAhg/K6mm44ddkIR 5ibI2AHwM2wiYzlOQjSluVZWCxHnTMs8zU2i50Xj08iGaSUx1m+YI3C0ZFA7z5duXBY3 YwiP2EYJ5rPAcvG4qcwp2bQ+VehGB+9e0Kp0iKoY4Dsj3949TMi6r0HIx+/5Xu8G7GfY iNBA== X-Gm-Message-State: AC+VfDzSNQJ1+cg+a8xN1+G33/dHK66QzNQTe4GsRbtLfusNkxvum0sJ 8wnZGYAUNl/re6bVki5813/3ow== X-Google-Smtp-Source: ACHHUZ5a5P5mqNb85Pd/vXMXSm7nE4E7+voSPGauH9t/Ggi2PDbGp1xcEDYRTN/Lmu7n3ZvVuqakoQ== X-Received: by 2002:a17:902:f54f:b0:1b2:24e4:8889 with SMTP id h15-20020a170902f54f00b001b224e48889mr2373341plf.14.1686147044665; Wed, 07 Jun 2023 07:10:44 -0700 (PDT) Received: from ziepe.ca ([206.223.160.26]) by smtp.gmail.com with ESMTPSA id t9-20020a170902bc4900b001b0772fe3fdsm10516761plz.265.2023.06.07.07.10.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Jun 2023 07:10:44 -0700 (PDT) Received: from jgg by wakko with local (Exim 4.95) (envelope-from ) id 1q6ts2-0039y5-6X; Wed, 07 Jun 2023 11:10:42 -0300 Date: Wed, 7 Jun 2023 11:10:42 -0300 From: Jason Gunthorpe To: Jakub Kicinski Cc: Saeed Mahameed , "David S. Miller" , Paolo Abeni , Eric Dumazet , Saeed Mahameed , netdev@vger.kernel.org, Tariq Toukan , Leon Romanovsky , linux-rdma@vger.kernel.org, Jiri Pirko Subject: Re: [net-next 13/15] net/mlx5: Skip inline mode check after mlx5_eswitch_enable_locked() failure Message-ID: References: <20230606071219.483255-1-saeed@kernel.org> <20230606071219.483255-14-saeed@kernel.org> <20230606220117.0696be3e@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230606220117.0696be3e@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On Tue, Jun 06, 2023 at 10:01:17PM -0700, Jakub Kicinski wrote: > On Tue, 6 Jun 2023 00:12:17 -0700 Saeed Mahameed wrote: > > Fixes: bffaa916588e ("net/mlx5: E-Switch, Add control for inline mode") > > Fixes: 8c98ee77d911 ("net/mlx5e: E-Switch, Add extack messages to devlink callbacks") > > The combination of net-next and Fixes is always odd. > Why? > Either it's important enough to be a fix or its not important > and can go to net-next... Generally I tell people to mark things as Fixes if it is a fix, regardless of how small, minor or unimportant. It helps backporters because they can suck in the original patch and all the touchups then test that result. If people try to predict if it is "important" or not they get it wrong quite often. Fixes is not supposed to mean "this is important" or "send this to -rc" or "apply it to -stable" If it is really important add a 'cc: stable'. If it is sort of important then send it to the -rc tree. Otherwise dump it in the merge window. But mark it with Fixes regardless Jason