* [PATCH] RDMA/vmw_pvrdma: Remove unnecessary check on wr->opcode
@ 2023-06-05 18:37 bryantan
2023-06-09 17:14 ` Jason Gunthorpe
0 siblings, 1 reply; 2+ messages in thread
From: bryantan @ 2023-06-05 18:37 UTC (permalink / raw)
To: linux-rdma, jgg, leon; +Cc: Bryan Tan, Dan Carpenter
From: Bryan Tan <bryantan@vmware.com>
wr->opcode is unsigned; checking if it is negative is unnecessary.
Fix this issue by removing the check.
Fixes: 29c8d9eba550 ("IB: Add vmw_pvrdma driver")
Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: Bryan Tan <bryantan@vmware.com>
---
drivers/infiniband/hw/vmw_pvrdma/pvrdma_qp.c | 8 --------
1 file changed, 8 deletions(-)
diff --git a/drivers/infiniband/hw/vmw_pvrdma/pvrdma_qp.c b/drivers/infiniband/hw/vmw_pvrdma/pvrdma_qp.c
index f83cd4a9d992..98b2a0090bf2 100644
--- a/drivers/infiniband/hw/vmw_pvrdma/pvrdma_qp.c
+++ b/drivers/infiniband/hw/vmw_pvrdma/pvrdma_qp.c
@@ -709,14 +709,6 @@ int pvrdma_post_send(struct ib_qp *ibqp, const struct ib_send_wr *wr,
goto out;
}
- if (unlikely(wr->opcode < 0)) {
- dev_warn_ratelimited(&dev->pdev->dev,
- "invalid send opcode\n");
- *bad_wr = wr;
- ret = -EINVAL;
- goto out;
- }
-
/*
* Only support UD, RC.
* Need to check opcode table for thorough checking.
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] RDMA/vmw_pvrdma: Remove unnecessary check on wr->opcode
2023-06-05 18:37 [PATCH] RDMA/vmw_pvrdma: Remove unnecessary check on wr->opcode bryantan
@ 2023-06-09 17:14 ` Jason Gunthorpe
0 siblings, 0 replies; 2+ messages in thread
From: Jason Gunthorpe @ 2023-06-09 17:14 UTC (permalink / raw)
To: bryantan; +Cc: linux-rdma, leon, Dan Carpenter
On Mon, Jun 05, 2023 at 11:37:28AM -0700, bryantan@vmware.com wrote:
> From: Bryan Tan <bryantan@vmware.com>
>
> wr->opcode is unsigned; checking if it is negative is unnecessary.
> Fix this issue by removing the check.
>
> Fixes: 29c8d9eba550 ("IB: Add vmw_pvrdma driver")
> Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
> Signed-off-by: Bryan Tan <bryantan@vmware.com>
> ---
> drivers/infiniband/hw/vmw_pvrdma/pvrdma_qp.c | 8 --------
> 1 file changed, 8 deletions(-)
Applied to for-next, thanks
Jason
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-06-09 17:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-06-05 18:37 [PATCH] RDMA/vmw_pvrdma: Remove unnecessary check on wr->opcode bryantan
2023-06-09 17:14 ` Jason Gunthorpe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).