From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31828C83005 for ; Sat, 10 Jun 2023 16:36:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229894AbjFJQgt (ORCPT ); Sat, 10 Jun 2023 12:36:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46696 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229965AbjFJQgr (ORCPT ); Sat, 10 Jun 2023 12:36:47 -0400 Received: from mail-ej1-x62a.google.com (mail-ej1-x62a.google.com [IPv6:2a00:1450:4864:20::62a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 46ABD3A97 for ; Sat, 10 Jun 2023 09:36:44 -0700 (PDT) Received: by mail-ej1-x62a.google.com with SMTP id a640c23a62f3a-974638ed5c5so592853566b.1 for ; Sat, 10 Jun 2023 09:36:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20221208.gappssmtp.com; s=20221208; t=1686415002; x=1689007002; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=X8VbRFbQOuqhFAPglq3rUuEFETDHIQvOfBEZigyYE00=; b=fcZwhYQXbZrGUCxD2cxWjeGu7RFEU0ScoH6Fu1j8oZlTPWxdTpxZpMcmjp2EzDf/9d FfZHTb9Jegul55u7V0zCjPzL5GRZCoYWPuup8y0FgDEX/VE4abtLSaelCPLmqGhOFvXf 0hiMFMG0SHOUJHmTFAtrpSUozKDhB5uBNbxOAm1l9CSRT6MqowUWZKvUTc/wZ1A942wY p8bL7na2XtF6nwgC4GwchfUxPf/wCWr8c/90iLSEeM82o53tpfNniHl2LweqNqiJTqEo 8La/4VPf8P1Wsh/9IK2QftfK8rl0/botcKtufVlRAOULG+cZ15IapPXlNaqykMscXVUg hfOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686415002; x=1689007002; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=X8VbRFbQOuqhFAPglq3rUuEFETDHIQvOfBEZigyYE00=; b=dTKPJS7aL3KYy7YtwnglG9t0OLBtnjccl+Fn+zsMdlB2C9KIFKfOtJE3gMFbaE8AgT e+bqfJtksoRN8HLCdyjEDBol3DkFMjU++U90EZrMZXa8NhN9HbaWlgdU1Cj8P2XRBK84 zR5Msq4+Bhi8GX5OSxjLQ+KhT3tVsBQMrgtm60HA70iSoJXlJgi2BC9MM1BFxqf8jsDr QFyRUqWuow2WsioypJ3mrFOWXWxOhG4XdFCfIh5JZ8CWx06nr3nxWnwCKZLpd15JoW+l rA5M1Yto98K7lGngDo4GfN9WA3MY0REMCKkLKHD4lCt5mpOfDP/I+T0J2EIvsnSEHV7N LtUQ== X-Gm-Message-State: AC+VfDwkrjmp2ZZPb1rsqK3EtdwssqSJopAh+NZQ70VHHMf7vBbu+T98 nyrcrliGpIRLjc4Dyt7jmdRxdw== X-Google-Smtp-Source: ACHHUZ4Vwbn5FWH4cTwcJAta6H8LObUb+MmlwTVJNnxgyTP9w4AqfMkvEAq7AY8i3/cgxY1KiIKmkw== X-Received: by 2002:a17:906:58c5:b0:974:5e8b:fc28 with SMTP id e5-20020a17090658c500b009745e8bfc28mr5052733ejs.9.1686415002366; Sat, 10 Jun 2023 09:36:42 -0700 (PDT) Received: from localhost (host-213-179-129-39.customer.m-online.net. [213.179.129.39]) by smtp.gmail.com with ESMTPSA id t16-20020a1709064f1000b0096f89fd4bf8sm2728669eju.122.2023.06.10.09.36.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 10 Jun 2023 09:36:41 -0700 (PDT) Date: Sat, 10 Jun 2023 18:36:40 +0200 From: Jiri Pirko To: Arkadiusz Kubalewski Cc: kuba@kernel.org, vadfed@meta.com, jonathan.lemon@gmail.com, pabeni@redhat.com, corbet@lwn.net, davem@davemloft.net, edumazet@google.com, vadfed@fb.com, jesse.brandeburg@intel.com, anthony.l.nguyen@intel.com, saeedm@nvidia.com, leon@kernel.org, richardcochran@gmail.com, sj@kernel.org, javierm@redhat.com, ricardo.canuelo@collabora.com, mst@redhat.com, tzimmermann@suse.de, michal.michalik@intel.com, gregkh@linuxfoundation.org, jacek.lawrynowicz@linux.intel.com, airlied@redhat.com, ogabbay@kernel.org, arnd@arndb.de, nipun.gupta@amd.com, axboe@kernel.dk, linux@zary.sk, masahiroy@kernel.org, benjamin.tissoires@redhat.com, geert+renesas@glider.be, milena.olech@intel.com, kuniyu@amazon.com, liuhangbin@gmail.com, hkallweit1@gmail.com, andy.ren@getcruise.com, razor@blackwall.org, idosch@nvidia.com, lucien.xin@gmail.com, nicolas.dichtel@6wind.com, phil@nwl.cc, claudiajkang@gmail.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org, linux-rdma@vger.kernel.org, linux-arm-kernel@lists.infradead.org, poros@redhat.com, mschmidt@redhat.com, linux-clk@vger.kernel.org, vadim.fedorenko@linux.dev Subject: Re: [RFC PATCH v8 08/10] ice: implement dpll interface to control cgu Message-ID: References: <20230609121853.3607724-1-arkadiusz.kubalewski@intel.com> <20230609121853.3607724-9-arkadiusz.kubalewski@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230609121853.3607724-9-arkadiusz.kubalewski@intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org Fri, Jun 09, 2023 at 02:18:51PM CEST, arkadiusz.kubalewski@intel.com wrote: [...] >+static int ice_dpll_mode_get(const struct dpll_device *dpll, void *priv, >+ enum dpll_mode *mode, >+ struct netlink_ext_ack *extack) >+{ >+ *mode = DPLL_MODE_AUTOMATIC; I don't understand how the automatic mode could work with SyncE. The There is one pin exposed for one netdev. The SyncE daemon should select exacly one pin. How do you achieve that? Is is by setting DPLL_PIN_STATE_SELECTABLE on the pin-netdev you want to select and DPLL_PIN_STATE_DISCONNECTED on the rest? [...]