From: Jason Gunthorpe <jgg@nvidia.com>
To: Bob Pearson <rpearsonhpe@gmail.com>
Cc: zyjzyj2000@gmail.com, linux-rdma@vger.kernel.org
Subject: Re: [PATCH for-next] RDMA/rxe: Simplify cq->notify code
Date: Tue, 20 Jun 2023 12:46:59 -0300 [thread overview]
Message-ID: <ZJHJ88dfRADoMP3b@nvidia.com> (raw)
In-Reply-To: <20230612162244.20038-1-rpearsonhpe@gmail.com>
On Mon, Jun 12, 2023 at 11:22:45AM -0500, Bob Pearson wrote:
> The flags parameter to the request notify verb is a bitmask. But,
> rxe driver treats cq->notify as an int. If someone ever set both
> the IB_CQ_SOLICITED and the IB_CQ_NEXT_COMP bits rxe_cq_post
> could fail to generate a completion event. This patch treats
> the notify flags as a bit mask consistently and can handle the
> above case correctly.
>
> Signed-off-by: Bob Pearson <rpearsonhpe@gmail.com>
> ---
> drivers/infiniband/sw/rxe/rxe_cq.c | 5 ++---
> drivers/infiniband/sw/rxe/rxe_verbs.c | 5 +----
> 2 files changed, 3 insertions(+), 7 deletions(-)
Applied to for-next, thanks
Jason
prev parent reply other threads:[~2023-06-20 15:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-12 16:22 [PATCH for-next] RDMA/rxe: Simplify cq->notify code Bob Pearson
2023-06-20 15:46 ` Jason Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZJHJ88dfRADoMP3b@nvidia.com \
--to=jgg@nvidia.com \
--cc=linux-rdma@vger.kernel.org \
--cc=rpearsonhpe@gmail.com \
--cc=zyjzyj2000@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).