[PATCH for-rc 0/3] RDMA/bnxt_re: Bug fixes

[PATCH for-rc 0/3] RDMA/bnxt_re: Bug fixes

[Selvin Xavier]

[-- Attachment #1: Type: text/plain, Size: 439 bytes --]

Includes few bug fixes in the driver.
Please review and apply.

Thanks,
Selvin

Kalesh AP (1):
  RDMA/bnxt_re: Fix error handling in probe failure path

Kashyap Desai (1):
  RDMA/bnxt_re: Initialize dpi_tbl_lock mutex

Selvin Xavier (1):
  RDMA/bnxt_re: Fix ib device unalloc

 drivers/infiniband/hw/bnxt_re/main.c      | 4 +++-
 drivers/infiniband/hw/bnxt_re/qplib_res.c | 1 +
 2 files changed, 4 insertions(+), 1 deletion(-)

-- 
2.5.5


[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4224 bytes --]

[PATCH for-rc 1/3] RDMA/bnxt_re: Fix ib device unalloc

[Selvin Xavier]

[-- Attachment #1: Type: text/plain, Size: 831 bytes --]

ib_dealloc_device should be called only after device cleanup.
Fix the dealloc sequence.

Fixes: 6d758147c7b8 ("RDMA/bnxt_re: Use auxiliary driver interface")
Signed-off-by: Selvin Xavier <selvin.xavier@broadcom.com>
---
 drivers/infiniband/hw/bnxt_re/main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/infiniband/hw/bnxt_re/main.c b/drivers/infiniband/hw/bnxt_re/main.c
index b42166f..1c76460 100644
--- a/drivers/infiniband/hw/bnxt_re/main.c
+++ b/drivers/infiniband/hw/bnxt_re/main.c
@@ -1526,8 +1526,8 @@ static void bnxt_re_remove(struct auxiliary_device *adev)
 	}
 	bnxt_re_setup_cc(rdev, false);
 	ib_unregister_device(&rdev->ibdev);
-	ib_dealloc_device(&rdev->ibdev);
 	bnxt_re_dev_uninit(rdev);
+	ib_dealloc_device(&rdev->ibdev);
 skip_remove:
 	mutex_unlock(&bnxt_re_mutex);
 }
-- 
2.5.5


[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4224 bytes --]

[PATCH for-rc 2/3] RDMA/bnxt_re: Fix error handling in probe failure path

[Selvin Xavier]

[-- Attachment #1: Type: text/plain, Size: 1001 bytes --]

From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>

During bnxt_re_dev_init(), when bnxt_re_setup_chip_ctx() fails
unregister with L2 first before bailing out probe.

Fixes: ae8637e13185 ("RDMA/bnxt_re: Add chip context to identify 57500 series")
Signed-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
Signed-off-by: Selvin Xavier <selvin.xavier@broadcom.com>
---
 drivers/infiniband/hw/bnxt_re/main.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/infiniband/hw/bnxt_re/main.c b/drivers/infiniband/hw/bnxt_re/main.c
index 1c76460..63e98e2 100644
--- a/drivers/infiniband/hw/bnxt_re/main.c
+++ b/drivers/infiniband/hw/bnxt_re/main.c
@@ -1253,6 +1253,8 @@ static int bnxt_re_dev_init(struct bnxt_re_dev *rdev, u8 wqe_mode)
 
 	rc = bnxt_re_setup_chip_ctx(rdev, wqe_mode);
 	if (rc) {
+		bnxt_unregister_dev(rdev->en_dev);
+		clear_bit(BNXT_RE_FLAG_NETDEV_REGISTERED, &rdev->flags);
 		ibdev_err(&rdev->ibdev, "Failed to get chip context\n");
 		return -EINVAL;
 	}
-- 
2.5.5


[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4224 bytes --]

[PATCH for-rc 3/3] RDMA/bnxt_re: Initialize dpi_tbl_lock mutex

[Selvin Xavier]

[-- Attachment #1: Type: text/plain, Size: 837 bytes --]

From: Kashyap Desai <kashyap.desai@broadcom.com>

Fix the missing dpi_tbl_lock mutex initialization

Fixes: 0ac20faf5d83 ("RDMA/bnxt_re: Reorg the bar mapping")
Signed-off-by: Kashyap Desai <kashyap.desai@broadcom.com>
Signed-off-by: Selvin Xavier <selvin.xavier@broadcom.com>
---
 drivers/infiniband/hw/bnxt_re/qplib_res.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/infiniband/hw/bnxt_re/qplib_res.c b/drivers/infiniband/hw/bnxt_re/qplib_res.c
index 5fd8f7c..739d942 100644
--- a/drivers/infiniband/hw/bnxt_re/qplib_res.c
+++ b/drivers/infiniband/hw/bnxt_re/qplib_res.c
@@ -819,6 +819,7 @@ static int bnxt_qplib_alloc_dpi_tbl(struct bnxt_qplib_res *res,
 	}
 
 	memset((u8 *)dpit->tbl, 0xFF, bytes);
+	mutex_init(&res->dpi_tbl_lock);
 	dpit->priv_db = dpit->ucreg.bar_reg + dpit->ucreg.offset;
 
 	return 0;
-- 
2.5.5


[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4224 bytes --]

Re: [PATCH for-rc 0/3] RDMA/bnxt_re: Bug fixes

[Jason Gunthorpe]

On Wed, Aug 09, 2023 at 09:44:34PM -0700, Selvin Xavier wrote:
> Includes few bug fixes in the driver.
> Please review and apply.
> 
> Thanks,
> Selvin
> 
> Kalesh AP (1):
>   RDMA/bnxt_re: Fix error handling in probe failure path
> 
> Kashyap Desai (1):
>   RDMA/bnxt_re: Initialize dpi_tbl_lock mutex
> 
> Selvin Xavier (1):
>   RDMA/bnxt_re: Fix ib device unalloc

Applied to for-rc, thanks

Jason