* [PATCH net-next] RDS: IB: Remove unused declarations
@ 2023-08-09 14:18 Yue Haibing
2023-08-10 18:08 ` Simon Horman
0 siblings, 1 reply; 6+ messages in thread
From: Yue Haibing @ 2023-08-09 14:18 UTC (permalink / raw)
To: santosh.shilimkar, davem, edumazet, kuba, pabeni, yuehaibing
Cc: netdev, linux-rdma, rds-devel
Commit f4f943c958a2 ("RDS: IB: ack more receive completions to improve performance")
removed rds_ib_recv_tasklet_fn() implementation but not the declaration.
And commit ec16227e1414 ("RDS/IB: Infiniband transport") declared but never implemented
the other functions.
Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
---
net/rds/ib.h | 4 ----
1 file changed, 4 deletions(-)
diff --git a/net/rds/ib.h b/net/rds/ib.h
index 2ba71102b1f1..8ef3178ed4d6 100644
--- a/net/rds/ib.h
+++ b/net/rds/ib.h
@@ -369,9 +369,6 @@ int rds_ib_conn_alloc(struct rds_connection *conn, gfp_t gfp);
void rds_ib_conn_free(void *arg);
int rds_ib_conn_path_connect(struct rds_conn_path *cp);
void rds_ib_conn_path_shutdown(struct rds_conn_path *cp);
-void rds_ib_state_change(struct sock *sk);
-int rds_ib_listen_init(void);
-void rds_ib_listen_stop(void);
__printf(2, 3)
void __rds_ib_conn_error(struct rds_connection *conn, const char *, ...);
int rds_ib_cm_handle_connect(struct rdma_cm_id *cm_id,
@@ -402,7 +399,6 @@ void rds_ib_inc_free(struct rds_incoming *inc);
int rds_ib_inc_copy_to_user(struct rds_incoming *inc, struct iov_iter *to);
void rds_ib_recv_cqe_handler(struct rds_ib_connection *ic, struct ib_wc *wc,
struct rds_ib_ack_state *state);
-void rds_ib_recv_tasklet_fn(unsigned long data);
void rds_ib_recv_init_ring(struct rds_ib_connection *ic);
void rds_ib_recv_clear_ring(struct rds_ib_connection *ic);
void rds_ib_recv_init_ack(struct rds_ib_connection *ic);
--
2.34.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH net-next] RDS: IB: Remove unused declarations
2023-08-09 14:18 [PATCH net-next] RDS: IB: Remove unused declarations Yue Haibing
@ 2023-08-10 18:08 ` Simon Horman
0 siblings, 0 replies; 6+ messages in thread
From: Simon Horman @ 2023-08-10 18:08 UTC (permalink / raw)
To: Yue Haibing
Cc: santosh.shilimkar, davem, edumazet, kuba, pabeni, netdev,
linux-rdma, rds-devel
On Wed, Aug 09, 2023 at 10:18:06PM +0800, Yue Haibing wrote:
> Commit f4f943c958a2 ("RDS: IB: ack more receive completions to improve performance")
> removed rds_ib_recv_tasklet_fn() implementation but not the declaration.
> And commit ec16227e1414 ("RDS/IB: Infiniband transport") declared but never implemented
> the other functions.
>
> Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
Reviewed-by: Simon Horman <horms@kernel.org>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH net-next] RDS: IB: Remove unused declarations
@ 2024-07-31 6:36 Yue Haibing
2024-07-31 10:12 ` Yue Haibing
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Yue Haibing @ 2024-07-31 6:36 UTC (permalink / raw)
To: allison.henderson, davem, edumazet, kuba, pabeni, yuehaibing
Cc: netdev, linux-rdma, rds-devel, linux-kernel
Commit f4f943c958a2 ("RDS: IB: ack more receive completions to improve performance")
removed rds_ib_recv_tasklet_fn() implementation but not the declaration.
And commit ec16227e1414 ("RDS/IB: Infiniband transport") declared but never implemented
other functions.
Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
Reviewed-by: Simon Horman <horms@kernel.org>
---
net/rds/ib.h | 4 ----
1 file changed, 4 deletions(-)
diff --git a/net/rds/ib.h b/net/rds/ib.h
index 2ba71102b1f1..8ef3178ed4d6 100644
--- a/net/rds/ib.h
+++ b/net/rds/ib.h
@@ -369,9 +369,6 @@ int rds_ib_conn_alloc(struct rds_connection *conn, gfp_t gfp);
void rds_ib_conn_free(void *arg);
int rds_ib_conn_path_connect(struct rds_conn_path *cp);
void rds_ib_conn_path_shutdown(struct rds_conn_path *cp);
-void rds_ib_state_change(struct sock *sk);
-int rds_ib_listen_init(void);
-void rds_ib_listen_stop(void);
__printf(2, 3)
void __rds_ib_conn_error(struct rds_connection *conn, const char *, ...);
int rds_ib_cm_handle_connect(struct rdma_cm_id *cm_id,
@@ -402,7 +399,6 @@ void rds_ib_inc_free(struct rds_incoming *inc);
int rds_ib_inc_copy_to_user(struct rds_incoming *inc, struct iov_iter *to);
void rds_ib_recv_cqe_handler(struct rds_ib_connection *ic, struct ib_wc *wc,
struct rds_ib_ack_state *state);
-void rds_ib_recv_tasklet_fn(unsigned long data);
void rds_ib_recv_init_ring(struct rds_ib_connection *ic);
void rds_ib_recv_clear_ring(struct rds_ib_connection *ic);
void rds_ib_recv_init_ack(struct rds_ib_connection *ic);
--
2.34.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH net-next] RDS: IB: Remove unused declarations
2024-07-31 6:36 Yue Haibing
@ 2024-07-31 10:12 ` Yue Haibing
2024-07-31 18:31 ` Allison Henderson
2024-08-01 16:10 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 6+ messages in thread
From: Yue Haibing @ 2024-07-31 10:12 UTC (permalink / raw)
To: allison.henderson, davem, edumazet, kuba, pabeni
Cc: netdev, linux-rdma, rds-devel, linux-kernel, Simon Horman
+CC Simon Horman <horms@kernel.org>
On 2024/7/31 14:36, Yue Haibing wrote:
> Commit f4f943c958a2 ("RDS: IB: ack more receive completions to improve performance")
> removed rds_ib_recv_tasklet_fn() implementation but not the declaration.
> And commit ec16227e1414 ("RDS/IB: Infiniband transport") declared but never implemented
> other functions.
>
> Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
> Reviewed-by: Simon Horman <horms@kernel.org>
> ---
> net/rds/ib.h | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/net/rds/ib.h b/net/rds/ib.h
> index 2ba71102b1f1..8ef3178ed4d6 100644
> --- a/net/rds/ib.h
> +++ b/net/rds/ib.h
> @@ -369,9 +369,6 @@ int rds_ib_conn_alloc(struct rds_connection *conn, gfp_t gfp);
> void rds_ib_conn_free(void *arg);
> int rds_ib_conn_path_connect(struct rds_conn_path *cp);
> void rds_ib_conn_path_shutdown(struct rds_conn_path *cp);
> -void rds_ib_state_change(struct sock *sk);
> -int rds_ib_listen_init(void);
> -void rds_ib_listen_stop(void);
> __printf(2, 3)
> void __rds_ib_conn_error(struct rds_connection *conn, const char *, ...);
> int rds_ib_cm_handle_connect(struct rdma_cm_id *cm_id,
> @@ -402,7 +399,6 @@ void rds_ib_inc_free(struct rds_incoming *inc);
> int rds_ib_inc_copy_to_user(struct rds_incoming *inc, struct iov_iter *to);
> void rds_ib_recv_cqe_handler(struct rds_ib_connection *ic, struct ib_wc *wc,
> struct rds_ib_ack_state *state);
> -void rds_ib_recv_tasklet_fn(unsigned long data);
> void rds_ib_recv_init_ring(struct rds_ib_connection *ic);
> void rds_ib_recv_clear_ring(struct rds_ib_connection *ic);
> void rds_ib_recv_init_ack(struct rds_ib_connection *ic);
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH net-next] RDS: IB: Remove unused declarations
2024-07-31 6:36 Yue Haibing
2024-07-31 10:12 ` Yue Haibing
@ 2024-07-31 18:31 ` Allison Henderson
2024-08-01 16:10 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 6+ messages in thread
From: Allison Henderson @ 2024-07-31 18:31 UTC (permalink / raw)
To: yuehaibing@huawei.com, edumazet@google.com, davem@davemloft.net,
kuba@kernel.org, pabeni@redhat.com
Cc: rds-devel@oss.oracle.com, netdev@vger.kernel.org,
linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org
On Wed, 2024-07-31 at 14:36 +0800, Yue Haibing wrote:
> Commit f4f943c958a2 ("RDS: IB: ack more receive completions to
> improve performance")
> removed rds_ib_recv_tasklet_fn() implementation but not the
> declaration.
> And commit ec16227e1414 ("RDS/IB: Infiniband transport") declared but
> never implemented
> other functions.
>
> Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
> Reviewed-by: Simon Horman <horms@kernel.org>
Hello Yue,
Thanks for finding these. The declarations do appear unused, so I
think it is fine to remove them. Thanks for the clean up.
Reviewed-by: Allison Henderson <allison.henderson@oracle.com>
> ---
> net/rds/ib.h | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/net/rds/ib.h b/net/rds/ib.h
> index 2ba71102b1f1..8ef3178ed4d6 100644
> --- a/net/rds/ib.h
> +++ b/net/rds/ib.h
> @@ -369,9 +369,6 @@ int rds_ib_conn_alloc(struct rds_connection
> *conn, gfp_t gfp);
> void rds_ib_conn_free(void *arg);
> int rds_ib_conn_path_connect(struct rds_conn_path *cp);
> void rds_ib_conn_path_shutdown(struct rds_conn_path *cp);
> -void rds_ib_state_change(struct sock *sk);
> -int rds_ib_listen_init(void);
> -void rds_ib_listen_stop(void);
> __printf(2, 3)
> void __rds_ib_conn_error(struct rds_connection *conn, const char *,
> ...);
> int rds_ib_cm_handle_connect(struct rdma_cm_id *cm_id,
> @@ -402,7 +399,6 @@ void rds_ib_inc_free(struct rds_incoming *inc);
> int rds_ib_inc_copy_to_user(struct rds_incoming *inc, struct
> iov_iter *to);
> void rds_ib_recv_cqe_handler(struct rds_ib_connection *ic, struct
> ib_wc *wc,
> struct rds_ib_ack_state *state);
> -void rds_ib_recv_tasklet_fn(unsigned long data);
> void rds_ib_recv_init_ring(struct rds_ib_connection *ic);
> void rds_ib_recv_clear_ring(struct rds_ib_connection *ic);
> void rds_ib_recv_init_ack(struct rds_ib_connection *ic);
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH net-next] RDS: IB: Remove unused declarations
2024-07-31 6:36 Yue Haibing
2024-07-31 10:12 ` Yue Haibing
2024-07-31 18:31 ` Allison Henderson
@ 2024-08-01 16:10 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 6+ messages in thread
From: patchwork-bot+netdevbpf @ 2024-08-01 16:10 UTC (permalink / raw)
To: Yue Haibing
Cc: allison.henderson, davem, edumazet, kuba, pabeni, netdev,
linux-rdma, rds-devel, linux-kernel
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Wed, 31 Jul 2024 14:36:30 +0800 you wrote:
> Commit f4f943c958a2 ("RDS: IB: ack more receive completions to improve performance")
> removed rds_ib_recv_tasklet_fn() implementation but not the declaration.
> And commit ec16227e1414 ("RDS/IB: Infiniband transport") declared but never implemented
> other functions.
>
> Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
> Reviewed-by: Simon Horman <horms@kernel.org>
>
> [...]
Here is the summary with links:
- [net-next] RDS: IB: Remove unused declarations
https://git.kernel.org/netdev/net-next/c/f9c141fc3339
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2024-08-01 16:10 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-08-09 14:18 [PATCH net-next] RDS: IB: Remove unused declarations Yue Haibing
2023-08-10 18:08 ` Simon Horman
-- strict thread matches above, loose matches on Subject: below --
2024-07-31 6:36 Yue Haibing
2024-07-31 10:12 ` Yue Haibing
2024-07-31 18:31 ` Allison Henderson
2024-08-01 16:10 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox