From: Jason Gunthorpe <jgg@nvidia.com>
To: "Daisuke Matsuda (Fujitsu)" <matsuda-daisuke@fujitsu.com>
Cc: "linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
"leonro@nvidia.com" <leonro@nvidia.com>,
"'leon@kernel.org'" <leon@kernel.org>,
"zyjzyj2000@gmail.com" <zyjzyj2000@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"rpearsonhpe@gmail.com" <rpearsonhpe@gmail.com>,
"Xiao Yang (Fujitsu)" <yangx.jy@fujitsu.com>,
"Zhijian Li (Fujitsu)" <lizhijian@fujitsu.com>,
"Yasunori Gotou (Fujitsu)" <y-goto@fujitsu.com>
Subject: Re: [PATCH for-next v5 6/7] RDMA/rxe: Add support for Send/Recv/Write/Read with ODP
Date: Fri, 8 Sep 2023 10:14:46 -0300 [thread overview]
Message-ID: <ZPseRunzsGSLeiGA@nvidia.com> (raw)
In-Reply-To: <OS7PR01MB11804464EB36E9E9FE02CA59BE5EDA@OS7PR01MB11804.jpnprd01.prod.outlook.com>
On Fri, Sep 08, 2023 at 06:35:56AM +0000, Daisuke Matsuda (Fujitsu) wrote:
> > IIRC this also needs to keep track in the xarray on a per page basis
> > if the page is writable.
>
> An xarray entry can hold a pointer or a value from 0 to LONG_MAX.
> That is not enough to store page address and its permission.
It is, this is a page list so you know the lower 12 bits are not used
and you can encode stuff there.
> If we try to do everything with xarray, we need to allocate a new struct
> for each page that holds a pointer to a page and a value to store r/w permission.
> That is inefficient in terms of memory usage and implementation.
No, just use the lower extra bits.
> I think the xarray can be used to check presence of pages just like we have
> been doing in the non-ODP case. On the other hand, the permission
> should be fetched from umem_odp->pfn_list, which is updated everytime
> page fault is executed.
Definately not
Jason
next prev parent reply other threads:[~2023-09-08 13:14 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-18 8:21 [PATCH for-next v5 0/7] On-Demand Paging on SoftRoCE Daisuke Matsuda
2023-05-18 8:21 ` [PATCH for-next v5 1/7] RDMA/rxe: Always defer tasks on responder and completer to workqueue Daisuke Matsuda
2023-05-18 8:26 ` Daisuke Matsuda (Fujitsu)
2023-05-18 22:25 ` Bob Pearson
2023-05-18 8:21 ` [PATCH for-next v5 2/7] RDMA/rxe: Make MR functions accessible from other rxe source code Daisuke Matsuda
2023-05-18 22:28 ` Bob Pearson
2023-05-18 8:21 ` [PATCH for-next v5 3/7] RDMA/rxe: Move resp_states definition to rxe_verbs.h Daisuke Matsuda
2023-05-18 22:30 ` Bob Pearson
2023-05-18 8:21 ` [PATCH for-next v5 4/7] RDMA/rxe: Add page invalidation support Daisuke Matsuda
2023-05-19 17:08 ` Bob Pearson
2023-05-18 8:21 ` [PATCH for-next v5 5/7] RDMA/rxe: Allow registering MRs for On-Demand Paging Daisuke Matsuda
2023-05-19 17:09 ` Bob Pearson
2023-06-12 16:18 ` Jason Gunthorpe
2023-07-19 6:00 ` Daisuke Matsuda (Fujitsu)
2023-07-21 18:46 ` Jason Gunthorpe
2023-05-18 8:21 ` [PATCH for-next v5 6/7] RDMA/rxe: Add support for Send/Recv/Write/Read with ODP Daisuke Matsuda
2023-05-19 17:10 ` Bob Pearson
2023-05-19 17:10 ` Bob Pearson
2023-06-12 16:22 ` Jason Gunthorpe
2023-07-19 6:01 ` Daisuke Matsuda (Fujitsu)
2023-09-08 6:35 ` Daisuke Matsuda (Fujitsu)
2023-09-08 13:14 ` Jason Gunthorpe [this message]
2023-05-18 8:21 ` [PATCH for-next v5 7/7] RDMA/rxe: Add support for the traditional Atomic operations " Daisuke Matsuda
2023-05-22 18:49 ` Bob Pearson
2023-05-19 6:41 ` [PATCH for-next v5 0/7] On-Demand Paging on SoftRoCE Guoqing Jiang
2023-05-19 9:57 ` Daisuke Matsuda (Fujitsu)
2023-05-19 10:20 ` Guoqing Jiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZPseRunzsGSLeiGA@nvidia.com \
--to=jgg@nvidia.com \
--cc=leon@kernel.org \
--cc=leonro@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=lizhijian@fujitsu.com \
--cc=matsuda-daisuke@fujitsu.com \
--cc=rpearsonhpe@gmail.com \
--cc=y-goto@fujitsu.com \
--cc=yangx.jy@fujitsu.com \
--cc=zyjzyj2000@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).