From: Jason Gunthorpe <jgg@ziepe.ca>
To: Zhu Yanjun <yanjun.zhu@linux.dev>
Cc: Bob Pearson <rpearsonhpe@gmail.com>,
"lizhijian@fujitsu.com" <lizhijian@fujitsu.com>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
Zhu Yanjun <zyjzyj2000@gmail.com>
Subject: Re: newlines in message macros
Date: Thu, 14 Sep 2023 09:52:12 -0300 [thread overview]
Message-ID: <ZQMB/MkCroFNuyrA@ziepe.ca> (raw)
In-Reply-To: <20fb88a8-6c68-671c-7791-be1df6f708d6@linux.dev>
On Thu, Sep 14, 2023 at 07:12:04AM +0800, Zhu Yanjun wrote:
> 在 2023/9/14 4:50, Bob Pearson 写道:
> > Li,
> >
> > I see that you removed the built-in newlines in the debug macros in rxe.h which is ok by me. But,
>
> I made tests for many times about adding newline speeding up flush messages.
> With or without new line, I can not find out the difference on flushing
> messages. Not sure if Li Zhijian found this difference in a specific
> scenario or not.
> And even without new line, after output the line, the message still goes to
> a new line. I suspect if a newline is appended in the PRINTK
> subsystem.
Kernel standard is to have newlines in the format strings.
Jason
next prev parent reply other threads:[~2023-09-14 12:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-13 20:50 newlines in message macros Bob Pearson
2023-09-13 21:10 ` Bob Pearson
2023-09-13 23:12 ` Zhu Yanjun
2023-09-14 12:52 ` Jason Gunthorpe [this message]
2023-09-15 1:38 ` Zhijian Li (Fujitsu)
2023-09-15 2:59 ` Zhu Yanjun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZQMB/MkCroFNuyrA@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=linux-rdma@vger.kernel.org \
--cc=lizhijian@fujitsu.com \
--cc=rpearsonhpe@gmail.com \
--cc=yanjun.zhu@linux.dev \
--cc=zyjzyj2000@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).