From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0366CE7543A for ; Tue, 3 Oct 2023 09:20:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231506AbjJCJUm (ORCPT ); Tue, 3 Oct 2023 05:20:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47624 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231509AbjJCJUl (ORCPT ); Tue, 3 Oct 2023 05:20:41 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A0BEBAC; Tue, 3 Oct 2023 02:20:37 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7ABD2C433C7; Tue, 3 Oct 2023 09:20:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1696324837; bh=kEex/DR+e1njfBDkl+EL3adoifBZXSVht3DKH7tUYRA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ArTUptzCqhOST0Uaoi72u5yMW0ydgIc86ROgVjTLFDFWxPTcOPQTUgzsMI141XE4q rIaY6q16ph24Ufu7uVZbwnLNCCDVSPll7IS0axSwfE7h2XK1BzeN+wf5v5R7O04t5D 9pVYACvLp2GYijTFvCguAi12ExIc6Lc2aQRNCUXMvvJAvSo/cx9GuFPE+ZGntMMqe+ mf4fZqq1o3XzdKLAZsVH4ZgUCttIEBs0Po4wNXHlLe6FDUUD9UCwthviFgnTd5/myj 7FHzg+gFe14HmKhB2rqR0+JTr3/PlS0uGCrMaJ9QykqZV4ucJcY3txIGXCS4JqX1D9 1YvjRcc/EcOeg== Date: Tue, 3 Oct 2023 11:20:29 +0200 From: Simon Horman To: Haiyang Zhang Cc: linux-hyperv@vger.kernel.org, netdev@vger.kernel.org, decui@microsoft.com, stephen@networkplumber.org, kys@microsoft.com, paulros@microsoft.com, olaf@aepfle.de, vkuznets@redhat.com, davem@davemloft.net, wei.liu@kernel.org, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, leon@kernel.org, longli@microsoft.com, ssengar@linux.microsoft.com, linux-rdma@vger.kernel.org, daniel@iogearbox.net, john.fastabend@gmail.com, bpf@vger.kernel.org, ast@kernel.org, sharmaajay@microsoft.com, hawk@kernel.org, tglx@linutronix.de, shradhagupta@linux.microsoft.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH net,v2, 3/3] net: mana: Fix oversized sge0 for GSO packets Message-ID: References: <1696020147-14989-1-git-send-email-haiyangz@microsoft.com> <1696020147-14989-4-git-send-email-haiyangz@microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1696020147-14989-4-git-send-email-haiyangz@microsoft.com> Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On Fri, Sep 29, 2023 at 01:42:27PM -0700, Haiyang Zhang wrote: > Handle the case when GSO SKB linear length is too large. > > MANA NIC requires GSO packets to put only the header part to SGE0, > otherwise the TX queue may stop at the HW level. > > So, use 2 SGEs for the skb linear part which contains more than the > packet header. > > Fixes: ca9c54d2d6a5 ("net: mana: Add a driver for Microsoft Azure Network Adapter (MANA)") > Signed-off-by: Haiyang Zhang > --- > v2: coding style updates suggested by Simon Horman Reviewed-by: Simon Horman