From: Etienne AUJAMES <eaujames@ddn.com>
To: Zhu Yanjun <zyjzyj2000@gmail.com>
Cc: jgg@ziepe.ca, leon@kernel.org, markzhang@nvidia.com,
shefty@nvidia.com,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
"Gael.DELBARY@cea.fr" <Gael.DELBARY@cea.fr>,
"guillaume.courrier@cea.fr" <guillaume.courrier@cea.fr>,
Serguei Smirnov <ssmirnov@whamcloud.com>,
Cyril Bordage <cbordage@whamcloud.com>
Subject: Re: [PATCH rdma-next v2] IB/cma: Define option to set max CM retries
Date: Wed, 24 Apr 2024 10:32:33 +0200 [thread overview]
Message-ID: <ZijDoVqOo9b6mgK7@eaujamesDDN> (raw)
In-Reply-To: <700c19e8-ae4f-42f0-a604-9e33a9a94dd3@linux.dev>
> > diff --git a/drivers/infiniband/core/cma.c b/drivers/infiniband/core/cma.c
> > index 1e2cd7c8716e..b6a73c7307ea 100644
> > --- a/drivers/infiniband/core/cma.c
> > +++ b/drivers/infiniband/core/cma.c
> > @@ -1002,6 +1002,7 @@ __rdma_create_id(struct net *net, rdma_cm_event_handler event_handler,
> > id_priv->tos_set = false;
> > id_priv->timeout_set = false;
> > id_priv->min_rnr_timer_set = false;
> > + id_priv->max_cm_retries = false;
>
> max_cm_retries is u8 type. Not sure if it is good to set it as false.
>
> Zhu Yanjun
>
Yes, my bad. Here, this should be max_cm_retries_set and not
max_cm_retries.
Etienne
prev parent reply other threads:[~2024-04-24 10:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-17 13:01 [PATCH rdma-next v2] IB/cma: Define option to set max CM retries Etienne AUJAMES
2024-04-23 15:42 ` Zhu Yanjun
2024-04-23 15:54 ` Sean Hefty
2024-04-24 8:41 ` Etienne AUJAMES
2024-04-24 8:32 ` Etienne AUJAMES [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZijDoVqOo9b6mgK7@eaujamesDDN \
--to=eaujames@ddn.com \
--cc=Gael.DELBARY@cea.fr \
--cc=cbordage@whamcloud.com \
--cc=guillaume.courrier@cea.fr \
--cc=jgg@ziepe.ca \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=markzhang@nvidia.com \
--cc=shefty@nvidia.com \
--cc=ssmirnov@whamcloud.com \
--cc=zyjzyj2000@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox