Re: [PATCH net-next 0/1] mlx5: Add netdev-genl queue stats

Joe Damato
2024-05-09T23:06:40Z

On Thu, May 09, 2024 at 12:42:11PM +0300, Tariq Toukan wrote:
> ..
>
> > > The off-channels queues (like PTP) do not exist in default. So they are out
> > > of the game unless you explicitly enables them.
> >
> > I did not enable them, but if you saw the thread, it sounds like Jakub's
> > preference is that in the v2 I include the PTP stats in get_base_stats.
> >
> > Are you OK with that?
>
> Sounds good.
>
> > Are there other queue stats I should include as well?
> >
>
> The QOS/HTB queues.
> See mlx5e_stats_grp_sw_update_stats_qos.

Sure, thanks, I can take a look. I think maybe an issue might be that if
I include QOS/HTB queues then tools/testing/selftests/drivers/net/stats.py
will start to fail.

I could be mistaken, but it seems that QOS/HTB are not included in the rtnl
stats, is that right?

If the goal is for queue stats to match rtnl then maybe I should leave
QOS/HTB out and they can be added to both RTNL and queue stats together at
a later time.