Re: [PATCH net-next 0/1] mlx5: Add netdev-genl queue stats

Jakub Kicinski
2024-05-04T00:34:30Z

On Fri, 3 May 2024 16:53:40 -0700 Joe Damato wrote:
> > diff --git a/include/net/netdev_queues.h b/include/net/netdev_queues.h
> > index c7ac4539eafc..f5d9f3ad5b66 100644
> > --- a/include/net/netdev_queues.h
> > +++ b/include/net/netdev_queues.h
> > @@ -59,6 +59,8 @@ struct netdev_queue_stats_tx {
> > * statistics will not generally add up to the total number of events for
> > * the device. The @get_base_stats callback allows filling in the delta
> > * between events for currently live queues and overall device history.
> > + * @get_base_stats can also be used to report any miscellaneous packets
> > + * transferred outside of the main set of queues used by the networking stack.
> > * When the statistics for the entire device are queried, first @get_base_stats
> > * is issued to collect the delta, and then a series of per-queue callbacks.
> > * Only statistics which are set in @get_base_stats will be reported
> >
> >
> > SG?
>
> I think that sounds good and makes sense, yea. By that definition, then I
> should leave the PTP stats as shown above. If you agree, I'll add that
> to the v2.

Yup, agreed.

> I feel like I should probably wait before sending a v2 with PTP included in
> get_base_stats to see if the Mellanox folks have any hints about why rtnl
> != queue stats on mlx5?
>
> What do you think?

Very odd, the code doesn't appear to be doing any magic :S Did you try
to print what the delta in values is? Does bringing the interface up and
down affect the size of it?