From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f172.google.com (mail-pf1-f172.google.com [209.85.210.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F2047EAE7 for ; Fri, 31 May 2024 18:30:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717180241; cv=none; b=IP4viBbkLlaCXxC9xBmAIlPlEEHKJL7rHprOXAMr05SyOJWsl7rDthlSE4n6xGJM945jJMPAoJXwsV4Tz7rBitDSeeKeH2V4Zh3/9QpJnLOOQ8sRYSl0YurBHVfkTwE1BTof4ufzUxanqQ6qWclbKb1uvRrNcsrFtI7iG6B+BrQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717180241; c=relaxed/simple; bh=YT/aQN35TGh8Chsjf5M28KpRij/hRyTR74fXiC+CKQs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=FH/giJf0JldxR9AvSOk2zzEjmU6HiopkPDAPgmlnyvsPkMAKGeOy/aXagBaBBuCWNkvUmMa/V1CWAVZWX5CXXCxrb9fPWsW5oIf7rRRClHnGhUJ/EESRcU6Lkgaya/dlc03Lw2ROslN3JQXQxdpewFbBIaURo3FN7thaiXieRE4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=fastly.com; spf=pass smtp.mailfrom=fastly.com; dkim=pass (1024-bit key) header.d=fastly.com header.i=@fastly.com header.b=hVxI+mdJ; arc=none smtp.client-ip=209.85.210.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=fastly.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fastly.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=fastly.com header.i=@fastly.com header.b="hVxI+mdJ" Received: by mail-pf1-f172.google.com with SMTP id d2e1a72fcca58-7024791a950so669195b3a.0 for ; Fri, 31 May 2024 11:30:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastly.com; s=google; t=1717180239; x=1717785039; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:from:to:cc :subject:date:message-id:reply-to; bh=QKzaRn43o/9ro5kVoZpov9f7l9ZGcLQ6ga/P6WrvCMw=; b=hVxI+mdJ1JIHQavwKz0L9E3mr8D6Y24GZINoIG2f+HjNFD2oOo5KY+JwTC9U2I8Rwc 6KvUoKgH4SpFXFJnRcwhvFB5Ikwp38pMSgf/zPfWJTO2cBNPggJ5qy6rxr50BWUEot1q NLlANUMtvCChSPin2ae+wVyWC1PdZJYt7n+Ew= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717180239; x=1717785039; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=QKzaRn43o/9ro5kVoZpov9f7l9ZGcLQ6ga/P6WrvCMw=; b=Zh2dJpMFEIGDh9Aqi2mkmZn9OGOuLN/I2d6ShssM++oeHVaT0Iv3SQK2v/pMsH21Mj oEJhpWHUYnKjhDXgGULEPFNPq5i0gNWMPvupIPvylvT0NtPEwLOX74bfefCGo8nqtA7L AIr0CkcmmmV6c663IhMGw58zcbkL0g1zJjFARjxZrJoA+39Mw1++nFILulh93cvjUfL0 +7FZj3prZOD0D6iJ1N5zVNd95+dTpGDnZmUlgfhWt9jlSsCtyW34FTFpIrIQuezR+BCm 7096m5bqBxvQu9yUmp4/1w5YQTih8F49FBJP1RdN1S0FPIa6x9N/nKW8ueFe9H1hMDok HhmA== X-Forwarded-Encrypted: i=1; AJvYcCUTcslG2sH442pqzfvu5dqtTQhH15QP5jWvCvFhWmW9lx+fdnslJxTBheYuNiHwX1zz9XChdnN3y6+W7JkzE6yRKe24O4qkBfiYTw== X-Gm-Message-State: AOJu0Yys48cAakAuy/EHgKA7h/A7PE7iW3pbbF+yWXCB9PO1kJuisohI 1bNOPY8t1hPezDsdKzT8W9io57vWNiJ7b0+RhgmaMG8hiZ6jf51syUzXVrhUCOc= X-Google-Smtp-Source: AGHT+IHDAof3GghhU3bST8irgoZ82PH9+1MMNRPtS18E3V7MNmIpQbpjcgm+hwpgfDuo91V5+iaOPA== X-Received: by 2002:a05:6a20:ce4b:b0:1af:58f8:1190 with SMTP id adf61e73a8af0-1b26f12a98bmr3112042637.12.1717180239224; Fri, 31 May 2024 11:30:39 -0700 (PDT) Received: from LQ3V64L9R2 (c-24-6-151-244.hsd1.ca.comcast.net. [24.6.151.244]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-70242b055dcsm1721722b3a.172.2024.05.31.11.30.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 May 2024 11:30:38 -0700 (PDT) Date: Fri, 31 May 2024 11:30:36 -0700 From: Joe Damato To: Jakub Kicinski Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, nalramli@fastly.com, "David S. Miller" , Eric Dumazet , Leon Romanovsky , "open list:MELLANOX MLX5 core VPI driver" , Paolo Abeni , Richard Cochran , Saeed Mahameed , Tariq Toukan Subject: Re: [RFC net-next v3 0/2] mlx5: Add netdev-genl queue stats Message-ID: Mail-Followup-To: Joe Damato , Jakub Kicinski , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, nalramli@fastly.com, "David S. Miller" , Eric Dumazet , Leon Romanovsky , "open list:MELLANOX MLX5 core VPI driver" , Paolo Abeni , Richard Cochran , Saeed Mahameed , Tariq Toukan References: <20240529031628.324117-1-jdamato@fastly.com> <20240530171128.35bd0ee2@kernel.org> <20240530182630.55139604@kernel.org> Precedence: bulk X-Mailing-List: linux-rdma@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240530182630.55139604@kernel.org> On Thu, May 30, 2024 at 06:26:30PM -0700, Jakub Kicinski wrote: > On Thu, 30 May 2024 18:07:31 -0700 Joe Damato wrote: > > Unless I am missing something, I think mlx5e_fold_sw_stats64 would > > need code similar to mlx5e_stats_grp_sw_update_stats_qos and then > > rtnl would account for htb stats. > > Hm, I think you're right. I'm just surprised this could have gone > unnoticed for so long. > > > That said: since it seems the htb numbers are not included right > > now, I was proposing adding that in later both to rtnl and > > netdev-genl together, hoping that would keep the proposed > > simpler/easier to get accepted. > > SGTM. Cool, so based on that it seems like I just need to figure out the correct implementation for base and tx stats that is correct and that will be accepted. Hoping to hear back from them soon as I'd personally love to have this API available on our systems.