From: Honggang LI <honggangli@163.com>
To: Zhu Yanjun <yanjun.zhu@linux.dev>
Cc: Greg Sword <gregsword0@gmail.com>,
zyjzyj2000@gmail.com, jgg@ziepe.ca, leon@kernel.org,
rpearsonhpe@gmail.com, linux-rdma@vger.kernel.org
Subject: Re: [PATCH] RDMA/rxe: Restore tasklet call for rxe_cq.c
Date: Fri, 12 Jul 2024 10:46:02 +0800 [thread overview]
Message-ID: <ZpCY6qKbWC89Aj9w@fc39> (raw)
In-Reply-To: <ebcebbc3-24c0-4a44-a08a-dc1ef2d1458b@linux.dev>
On Thu, Jul 11, 2024 at 03:46:24PM +0200, Zhu Yanjun wrote:
> Subject: Re: [PATCH] RDMA/rxe: Restore tasklet call for rxe_cq.c
> >
> > > Please explain the deadlock in details.
>
> I read the discussion carefully. I have the following:
> 1). This problem is not from RXE. It seems to be related with krping
> modules. As such, the root cause is not in RXE. It is not good to fix this
> problem in RXE.
Can't say it a problem in krping. As krping works over irdma/mlx5/siw.
The deadlock only happens with rxe.
>
> 2). In the kernel upstream, tasklet is marked obsolete and has some design
> flaws. So replacing workqueue with tasklet in RXE does not keep up with the
> kernel upstream.
>
> https://patchwork.kernel.org/project/linux-rdma/cover/20240621050525.3720069-1-allen.lkml@gmail.com/
> In this link, there are some work to replace tasklet with BH workqueue.
> As such, it is not good to replace workqueue with tasklet.
Yes, you are right. Tasklet is obsoleted. We need a better solution for
this issue. Please feel free to drop the patch.
next prev parent reply other threads:[~2024-07-12 2:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-11 1:40 [PATCH] RDMA/rxe: Restore tasklet call for rxe_cq.c Honggang LI
2024-07-11 3:06 ` Greg Sword
2024-07-11 7:01 ` Honggang LI
2024-07-11 13:46 ` Zhu Yanjun
2024-07-12 2:46 ` Honggang LI [this message]
2024-07-11 23:25 ` Zhu Yanjun
2024-09-15 12:26 ` Zhu Yanjun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZpCY6qKbWC89Aj9w@fc39 \
--to=honggangli@163.com \
--cc=gregsword0@gmail.com \
--cc=jgg@ziepe.ca \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=rpearsonhpe@gmail.com \
--cc=yanjun.zhu@linux.dev \
--cc=zyjzyj2000@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox